-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Keyboard: add A diacritics #4889
Conversation
Frenzie
commented
Apr 10, 2019
I'll rework this slightly with the suggestion from #4887 (comment) to externalize the popup definitions. |
Follow up to #4886 (comment):
Well, I don't know how much you care about that, but not seeing the |
The diaeresis wins two times out of three, and the circumflex never does.
1+2 = At equal weighting, 1+2+3 = |
"ē", | ||
} | ||
local en_popup = require("ui/data/keyboardlayouts/keypopup/en_popup") | ||
local _at = en_popup._at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poire-z Something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. std_popup.lua
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, except I'd rename std.lua to en_keyboard.lua. :-P
As a courtesy to technical users, will it be possible to have on a key on the first keyboard layout ( I'm thinking about |
I was planning to stick [ and ] on q and w. And yes, the . obviously needs all the regular punctuation options. tl;dr no worries ;-) |
@poire-z std.lua renamed & ready. For q and w, considering something like this:
|
For the
|
Try to make it easy to associate it in fr_keyboard with a and z then :)
For the dot at the bottom (as for the q at the left), it will be impossible to swipe down (resp left), and holdpanrelease left - so the chars on these sides will work only with tap. In both your suggestions, ! is the loser :) |
Anyway, I haven't really thought about those yet. Only the s has received a reasonable amount of thought: (I know, sizing isn't quite optimal there. One thing at a time.)
On holdrelease it taps the button you're on; it doesn't care about direction (which would be unintuitive, besides which the extra buttons would be inaccessible). Only swipes swipe. |
I could fill up extra with sigma ( |
I just updated my Kobo Aura One to v2019.04-9-gfd50dc3_2019-04-10, and now choosing "Book status" in the hamburger menu has KOReader exit irregularly (as reported by KSM). |
I'm not really sure why you'd randomly post that here instead of in a new issue? |
It seemed connected - as the Book status has a keyboard (in fact I went there in order to try your enhancements), and it seemed not unlikely the bug was related. |
Could you open a new issue with the crash.log included? |
I just did. #4899 |
Could you add the following to the = key, please? « ≠ » Thank you! And are there gestures associated with the two characters on the top line of a 4-line layout? Such as a hacek? |
Btw, the code behind the popup itself is somewhat complex, but I made the configuration very friendly. _z_ = {
"z",
northeast = "ź",
northwest = "ζ", -- zeta lowercase
west = "ž",
south = "ʐ", -- voiced retroflex sibilant fricative IPA
southeast = "ʒ", -- ezh, voiced palato-alveolar fricative IPA
southwest = "ż",
}, By <= you mean ≤ and ≥? |
Yes - I updated the comment. |
As suggested by @Biep in koreader#4889 (comment)
As suggested by @Biep in #4889 (comment)
Ah, you added it - thanks! Happy Easter! Χριστός ἀνέστη! Хрїсто́съ воскре́се! And of course from those who have given more will be begged..: Would it be possible to add arrow keys this way too? That swiping left or right on, say, the space bar, would move the cursor in that direction? If so, then NW and NE could mean delete left and delete right, respectively, freeing a key on the main keyboard. (The delete key(s) could still, with the arrow keys, be on a secondary keyboard.) And would it be possible to have different keys for Shift when the main key doesn't change? Just as an example, for the space bar again, could shift+swipe left mean move back a word? And concerning Shift itself: maybe just Shift could truly mean "shift" (make the next character upper case), wheras a N swipe on the key could mean "Caps lock", and a S swipe "Lowercase". (And if you start working on the Shift key anyway: W and E swipes could go to popular alternate alphabets, such as Greek and Cyrillic.) Is there a specific reason to have the full words (e.g. "northwest") rather than the abbreviations (e.g. "NW") in the configuration? I can even imagine names that pictorially show the gesture: straight and crooked arrows, or sequences of arrows as in the multiswipe menu. That would be language-independent and allow multiswipes (though it would require quoting). And to repeat my earlier question: are there gestures associated with the top row of keys in a four-row pop-up? |
Also rename std to en_keyboard.
As suggested by @Biep in koreader#4889 (comment)