[UX] VirtualKeyPopup: close on hold release

[Frenzie]

As suggested by @poire-z.

[poire-z]

There seems to be a refresh issue with current master, when pan'releas'ing:

With flash keyboard enabled and hitting where the s is hidden:

It's ok when tapping, and tapping outside to dismiss the popup.

[Frenzie]

That's on your Kobo?

[poire-z]

No, on the emulator, after just a git pull.

[Frenzie]

Lightbulb thought: do you have keyboard flash disabled?

[Frenzie]

And if so, does the setDirty from 4c4efca do the trick?

function VirtualKeyPopup:onClose()
    local dimen = self.dimen
    UIManager:close(self)
    UIManager:setDirty(self, function()
        return "partial", dimen
    end)
    return true
end

[poire-z]

Usually I have it disabled, but I tried both (with flash enabled, the s is shown on one of the screenshots above).

And if so, does the setDirty from 4c4efca do the trick?

Nope (just cut and pasted that at the bottom of virtualkeyboard.lua, no change).

(Sorry, leaving, can't test much till later this evening.)

[poire-z]

It looks like we (logically, as most widgets do) need to have this to avoid this refresh issue:

+function VirtualKeyPopup:onCloseWidget()
+    UIManager:setDirty(nil, function()
+        return "partial", self[1][1].dimen
+    end)
+end

(which is called by UIManager when we do UIManager:close(self)).

Without that, when tapping outside, we get a full screen refresh (not sure what triggers it):

04/10/19-22:53:16 DEBUG no refresh got enqueued. Will do a partial full screen refresh, which might be inefficient
04/10/19-22:53:16 DEBUG _refresh: Enqueued partial update for region 0 0 600 610

and nothing when pan'releas'ing.

With that, when tapping outside, we just get the popup region refreshed:

04/10/19-23:02:20 DEBUG _refresh: Enqueued partial update for region 58 287 186 217

and the same when pan'releas'ing.

It's strange that you don't reproduce it.