Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[UX] VirtualKeyPopup: close on hold release #4891
Apr 10, 2019
1 check was pending
Usually I have it disabled, but I tried both (with flash enabled, the s is shown on one of the screenshots above).
Nope (just cut and pasted that at the bottom of virtualkeyboard.lua, no change).
(Sorry, leaving, can't test much till later this evening.)
It looks like we (logically, as most widgets do) need to have this to avoid this refresh issue:
+function VirtualKeyPopup:onCloseWidget() + UIManager:setDirty(nil, function() + return "partial", self.dimen + end) +end
(which is called by UIManager when we do
Without that, when tapping outside, we get a full screen refresh (not sure what triggers it):
and nothing when pan'releas'ing.
With that, when tapping outside, we just get the popup region refreshed:
and the same when pan'releas'ing.
It's strange that you don't reproduce it.