Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Keyboard popups: stubs for the rest of the vowels (I, O, U) #4907

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Apr 12, 2019

With the basic pattern of diacritics and special characters established by now, the basic diacritics + IPA don't need too much thought for an initial draft.

Cf. #4906 (comment)

With the basic pattern of diacritics and special characters established by now, the basic diacritics + IPA don't need too much thought for an initial draft.

Cf. koreader#4906 (comment)
@Frenzie Frenzie added the UX label Apr 12, 2019
@Frenzie Frenzie added this to the 2019.05 milestone Apr 12, 2019
@Frenzie Frenzie merged commit 6f8a077 into koreader:master Apr 12, 2019
@Frenzie Frenzie deleted the keyboard-vowel-popups branch April 12, 2019 16:28
@gerhaher
Copy link

You have missed to include the norwegian/danish Ø.
It represents the same sound as the swedish Ö.

@Frenzie
Copy link
Member Author

Frenzie commented Apr 13, 2019

The southwest is reserved for it and it's the IPA character for the same sound. :-) But indeed, I might as well add it directly.

Frenzie added a commit to Frenzie/koreader that referenced this pull request Apr 13, 2019
Danish/Norse and IPA close-mid front rounded vowel.

Requested by @gerhaher over in koreader#4907 (comment)
Frenzie added a commit that referenced this pull request Apr 13, 2019
Danish/Norse and IPA close-mid front rounded vowel.

Requested by @gerhaher over in #4907 (comment)
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
…eader#4907)

With the basic pattern of diacritics and special characters established by now, the basic diacritics + IPA don't need too much thought for an initial draft.

Cf. koreader#4906 (comment)
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Danish/Norse and IPA close-mid front rounded vowel.

Requested by @gerhaher over in koreader#4907 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants