Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete book after reading #5107

Merged
merged 2 commits into from Jul 5, 2019
Merged

Conversation

robert00s
Copy link
Contributor

Close #5050
Add option to "delete" just read book to "End of document action".
Before:
00
01

After:

02
03

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comments @poire-z @NiLuJe ?

@Frenzie Frenzie added this to the 2019.07 milestone Jul 3, 2019
@poire-z
Copy link
Contributor

poire-z commented Jul 3, 2019

Long time no PR, welcome back :)

May be switch these 2: | Delete file | Open next file | ?
I see there is a ConfirmBox so no risk if we hit Delete file by error, but may be Open next file should be reachable more easily - instead of the destructive option?

Well, personally, I don't use any End of doc action - but if I were, I'd probbly use Delete file the most :) - So, I dunno, may be people will do that most often too... and so it's at the right place.

In the menu, may be move Delete file a bit up, so they are in the same order we see them in the button dialog - just for consistency?

@AlanSP1
Copy link

AlanSP1 commented Jul 3, 2019

Certainly very handy option to have. Thanks...

@NiLuJe
Copy link
Member

NiLuJe commented Jul 3, 2019

One random question: Does it wipe the sidecar? Should it?

@robert00s
Copy link
Contributor Author

@poire-z
I was busy a bit :)

May be switch these 2: | Delete file | Open next file | ?

Ok.

In the menu, may be move Delete file a bit up, so they are in the same order we see them in the button dialog - just for consistency?

Good point.

@NiLuJe

One random question: Does it wipe the sidecar? Should it?

Yes. Delete file option works exactly like delete in file browser. Delete file + .sdr + remove from history.

@Frenzie Frenzie merged commit 7d093fc into koreader:master Jul 5, 2019
@Eduardomb22
Copy link

Thanks for this update. I have a question, is it possible to add a option to exit koreader after the file is deleted instead of go to the filebrowser?

@robert00s robert00s deleted the delete_end_document branch November 23, 2019 18:23
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: delete book after reading - new "end of docuemnt action" popup action
6 participants