Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete book after reading #5107

Merged
merged 2 commits into from Jul 5, 2019

Conversation

@robert00s
Copy link
Contributor

commented Jul 3, 2019

Close #5050
Add option to "delete" just read book to "End of document action".
Before:
00
01

After:

02
03

@Frenzie

Frenzie approved these changes Jul 3, 2019

Copy link
Member

left a comment

Any comments @poire-z @NiLuJe ?

@Frenzie Frenzie added this to the 2019.07 milestone Jul 3, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Long time no PR, welcome back :)

May be switch these 2: | Delete file | Open next file | ?
I see there is a ConfirmBox so no risk if we hit Delete file by error, but may be Open next file should be reachable more easily - instead of the destructive option?

Well, personally, I don't use any End of doc action - but if I were, I'd probbly use Delete file the most :) - So, I dunno, may be people will do that most often too... and so it's at the right place.

In the menu, may be move Delete file a bit up, so they are in the same order we see them in the button dialog - just for consistency?

@AlanSP1

This comment has been minimized.

Copy link

commented Jul 3, 2019

Certainly very handy option to have. Thanks...

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

One random question: Does it wipe the sidecar? Should it?

@robert00s

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

@poire-z
I was busy a bit :)

May be switch these 2: | Delete file | Open next file | ?

Ok.

In the menu, may be move Delete file a bit up, so they are in the same order we see them in the button dialog - just for consistency?

Good point.

@NiLuJe

One random question: Does it wipe the sidecar? Should it?

Yes. Delete file option works exactly like delete in file browser. Delete file + .sdr + remove from history.

@poire-z

poire-z approved these changes Jul 4, 2019

@Frenzie Frenzie merged commit 7d093fc into koreader:master Jul 5, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Eduardomb22

This comment has been minimized.

Copy link

commented Jul 7, 2019

Thanks for this update. I have a question, is it possible to add a option to exit koreader after the file is deleted instead of go to the filebrowser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.