Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "empty folder" when accessing nextcloud webdav #5171

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@jp8
Copy link
Contributor

commented Aug 2, 2019

Using the cloud storage feature to connect to a NextCloud server (using WebDAV protocol) results in "/" for every folder name in the list, and "Empty Folder" messages when trying to access any folder.

The cause is a trailing slash in the response from the NextCloud server that needs to be handled if present.

fix "empty folder" when accessing nextcloud webdav
fix for cloud storage webdav nextcloud "empty folder" problem
@NiLuJe

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Which, arguably, is the right (as per specs) way to specify a URL (EDIT: With a trailing /, I mean) ;).

Nice catch, though!

@robert00s robert00s added this to the 2019.08 milestone Aug 3, 2019

@Frenzie Frenzie added the bug label Aug 3, 2019

@Frenzie Frenzie merged commit 47da960 into koreader:master Aug 3, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.