Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Pass plain link to link:onGotoLink #5286

Merged
merged 1 commit into from Aug 31, 2019

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Aug 31, 2019

Internal links carry more baggage than external ones.

See #5282 (comment).

Internal links carry more baggage than external ones.

See <koreader#5282 (comment)>.
@Frenzie Frenzie added the bug label Aug 31, 2019
@Frenzie Frenzie added this to the 2019.09 milestone Aug 31, 2019
Copy link
Contributor

@poire-z poire-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not tested, but looks good :)

@Frenzie Frenzie merged commit 37bab4f into koreader:master Aug 31, 2019
@Frenzie Frenzie deleted the fix-internal-link-crash branch August 31, 2019 10:43
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Internal links carry more baggage than external ones.

See <koreader#5282 (comment)>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants