Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Allow keyboard layout selection #5318

Merged
merged 3 commits into from
Sep 6, 2019

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Sep 4, 2019

Fixes #3998.

This isn't quite what I want but I've been letting this slip for
too long due to fancier keyboard interaction concepts.

Screenshot_2019-09-04_21-33-41
Screenshot_2019-09-04_21-33-49
Screenshot_2019-09-04_21-33-56

@Frenzie Frenzie added the UX label Sep 4, 2019
@Frenzie Frenzie added this to the 2019.09 milestone Sep 4, 2019
Fixes <koreader#3998>.

This is an unpolished quickie but I've been letting this slip for too
long due to fancier keyboard interaction concepts.
@poire-z
Copy link
Contributor

poire-z commented Sep 4, 2019

The order of the items is random (not the same in the file vs your screenshot) ?
Any chance to get them in some order (with may be en/default at first place)?
Would it make sense to give the menu item better names than these few letters? Or is that the classic naming for keyboards?
(Alternative, the 6 first letters of the keyboard, qwerty, azerty, ㅃㅉㄸㄲㅆㅛ, あかさたなは.)

@Frenzie
Copy link
Member Author

Frenzie commented Sep 4, 2019

That's part of what I mean by unpolished. ;-)

But sure, I can probably polish it at least a little tomorrow.

@Frenzie
Copy link
Member Author

Frenzie commented Sep 5, 2019

Screenshot_20190905_215814

@Frenzie
Copy link
Member Author

Frenzie commented Sep 6, 2019

@poire-z Do you think it's acceptable now for a first pass?

Copy link
Contributor

@poire-z poire-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks fine to me.

@Frenzie Frenzie merged commit 17e437d into koreader:master Sep 6, 2019
@Frenzie Frenzie deleted the keyboard-layout branch September 6, 2019 15:01
Frenzie added a commit to Frenzie/koreader that referenced this pull request Sep 7, 2019
Frenzie added a commit that referenced this pull request Sep 7, 2019
@noembryo
Copy link
Contributor

Just saw this and I wonder, should I change the el_keyboard.lua to make it that the Greek characters are default?

@Frenzie
Copy link
Member Author

Frenzie commented Sep 18, 2019

@noembryo If that's what people expect from a Greek keyboard then that's probably a good idea. Judging by this it looks like it should be delta for D, etc.?

@noembryo
Copy link
Contributor

Yeap..
I'll try a PR (I did one already from the browser, maybe I'll try one from inside my IDE ;o)

Frenzie pushed a commit that referenced this pull request Sep 18, 2019
Set the Greek characters as the default

Cf. #5318 (comment)
@Frenzie Frenzie mentioned this pull request Sep 18, 2019
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Fixes <koreader#3998>.

This isn't quite what I want but I've been letting this slip for
too long due to fancier keyboard interaction concepts.
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Set the Greek characters as the default

Cf. koreader#5318 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement to keyboard layout system
3 participants