Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Allow keyboard layout selection #5318

Merged
merged 3 commits into from Sep 6, 2019

Conversation

@Frenzie
Copy link
Member

commented Sep 4, 2019

Fixes #3998.

This isn't quite what I want but I've been letting this slip for
too long due to fancier keyboard interaction concepts.

Screenshot_2019-09-04_21-33-41
Screenshot_2019-09-04_21-33-49
Screenshot_2019-09-04_21-33-56

@Frenzie Frenzie added the UX label Sep 4, 2019

@Frenzie Frenzie added this to the 2019.09 milestone Sep 4, 2019

@Frenzie Frenzie force-pushed the Frenzie:keyboard-layout branch from 8860d5b to b77d433 Sep 4, 2019

[UX] Allow keyboard layout selection
Fixes <#3998>.

This is an unpolished quickie but I've been letting this slip for too
long due to fancier keyboard interaction concepts.

@Frenzie Frenzie force-pushed the Frenzie:keyboard-layout branch from 9f52ffe to c417f20 Sep 4, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

The order of the items is random (not the same in the file vs your screenshot) ?
Any chance to get them in some order (with may be en/default at first place)?
Would it make sense to give the menu item better names than these few letters? Or is that the classic naming for keyboards?
(Alternative, the 6 first letters of the keyboard, qwerty, azerty, ㅃㅉㄸㄲㅆㅛ, あかさたなは.)

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

That's part of what I mean by unpolished. ;-)

But sure, I can probably polish it at least a little tomorrow.

Frenzie added 2 commits Sep 5, 2019
@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

Screenshot_20190905_215814

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

@poire-z Do you think it's acceptable now for a first pass?

@poire-z
poire-z approved these changes Sep 6, 2019
Copy link
Contributor

left a comment

Yep, looks fine to me.

@Frenzie Frenzie merged commit 17e437d into koreader:master Sep 6, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:keyboard-layout branch Sep 6, 2019

Frenzie added a commit to Frenzie/koreader that referenced this pull request Sep 7, 2019
Frenzie added a commit that referenced this pull request Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.