Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PocketBook 614W (Basic 3) definition #6312

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Add PocketBook 614W (Basic 3) definition #6312

merged 4 commits into from
Jun 26, 2020

Conversation

roshavagarga
Copy link
Contributor

@roshavagarga roshavagarga commented Jun 26, 2020

Cf. <#6311>.


This change is Reviewable

@Frenzie Frenzie added this to the 2020.07 milestone Jun 26, 2020
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, besides the one nitpick

frontend/device/pocketbook/device.lua Outdated Show resolved Hide resolved
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
@roshavagarga
Copy link
Contributor Author

Just a small overview of those changes:

  1. I did not try dpi of 167, but it might work, just saw 166 in device specs, either one may be correct.
  2. I'm not sure what hasWifiToggle means, I guessed that it meant having a button to enable/disable WiFi, so I set it as no based on that.
  3. There may be other tags/options that I might have missed which may be appropriate for this device.

@Frenzie
Copy link
Member

Frenzie commented Jun 26, 2020

I did not try dpi of 167, but it might work, just saw 166 in device specs, either one may be correct.

Please stick to 167 for consistency. :-) (Also 166.6666… rounds up to 167.)

I'm not sure what hasWifiToggle means, I guessed that it meant having a button to enable/disable WiFi, so I set it as no based on that.

It's about if you can just tell it to toggle the wifi on/off, not a physical toggle iirc.

@roshavagarga
Copy link
Contributor Author

Changed it for consistency, but other devices seem to have it set to 166 instead of 167, so those might need to be changed too?

@roshavagarga
Copy link
Contributor Author

Within the native settings UI, there is a wifi menu, which has an on/off switch, so if that constitutes a Wifi Toggle, then I should probably change that too, right?

@Frenzie Frenzie merged commit 46bf88c into koreader:master Jun 26, 2020
@roshavagarga
Copy link
Contributor Author

Thanks for the merge, taking it that the wifi thing I found isn't a toggle 👍

@Frenzie
Copy link
Member

Frenzie commented Jun 26, 2020

Changed it for consistency, but other devices seem to have it set to 166 instead of 167, so those might need to be changed too?

If they round to 167, probably. It shouldn't affect anything other than perhaps people with OCD though. ^_^

Within the native settings UI, there is a wifi menu, which has an on/off switch, so if that constitutes a Wifi Toggle, then I should probably change that too, right?

I didn't really notice this before I merged, but that's more of a thing to determine experimentally. Does the wifi toggle in the KOReader menu work? That's Settings → Network → Wi-Fi connection. You'll probably have to uncomment or remove that hasWifiToggle line to test.

@roshavagarga
Copy link
Contributor Author

I'll test it out later, not sure I can enter that part of settings because of the whole hasFewKeys issues.

@Frenzie
Copy link
Member

Frenzie commented Jun 26, 2020

You can.

  1. Open a book.
  2. Press right.
  3. Navigate to settings (but I just realized it doesn't rotate, so that might be problematic if you're too far right)

@roshavagarga
Copy link
Contributor Author

If I remember correctly, I was stuck at the furthest to the right, if that one has it, I can test it, if not, no dice :)
Actually, now that I think about it, if both menus rotated and the 'left for leave' thing worked on the bottom menu like on the top one, it would be pretty usable even without remapping keys.

@Frenzie
Copy link
Member

Frenzie commented Jun 26, 2020

If I remember correctly, I was stuck at the furthest to the right, if that one has it, I can test it, if not, no dice :)

You can set the last opened menu in settings.reader.lua.

["filemanagermenu_tab_index"] = 4,
-- and probably readermenu_tab_index

Removing the line will reset it.

Actually, now that I think about it, if both menus rotated and the 'left for leave' thing worked on the bottom menu like on the top one, it would be pretty usable even without remapping keys.

Well yes, that's what I proposed, for starters anyway. That's very much with remapping keys though? ;-)

Frenzie added a commit to Frenzie/koreader that referenced this pull request Jun 26, 2020
There doesn't seem to be a reason not to, but it could be limited to `Device:hasFewKeys()` if desired.

Cf. <koreader#6312 (comment)>.
Frenzie added a commit that referenced this pull request Jun 27, 2020
There doesn't seem to be a reason not to, but it could be limited to `Device:hasFewKeys()` if desired.

Cf. <#6312 (comment)>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants