-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PocketBook 614W (Basic 3) definition #6312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, besides the one nitpick
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Just a small overview of those changes:
|
Please stick to 167 for consistency. :-) (Also 166.6666… rounds up to 167.)
It's about if you can just tell it to toggle the wifi on/off, not a physical toggle iirc. |
Changed it for consistency, but other devices seem to have it set to 166 instead of 167, so those might need to be changed too? |
Within the native settings UI, there is a wifi menu, which has an on/off switch, so if that constitutes a Wifi Toggle, then I should probably change that too, right? |
Thanks for the merge, taking it that the wifi thing I found isn't a toggle 👍 |
If they round to 167, probably. It shouldn't affect anything other than perhaps people with OCD though. ^_^
I didn't really notice this before I merged, but that's more of a thing to determine experimentally. Does the wifi toggle in the KOReader menu work? That's Settings → Network → Wi-Fi connection. You'll probably have to uncomment or remove that |
I'll test it out later, not sure I can enter that part of settings because of the whole hasFewKeys issues. |
You can.
|
If I remember correctly, I was stuck at the furthest to the right, if that one has it, I can test it, if not, no dice :) |
You can set the last opened menu in settings.reader.lua.
Removing the line will reset it.
Well yes, that's what I proposed, for starters anyway. That's very much with remapping keys though? ;-) |
There doesn't seem to be a reason not to, but it could be limited to `Device:hasFewKeys()` if desired. Cf. <koreader#6312 (comment)>.
There doesn't seem to be a reason not to, but it could be limited to `Device:hasFewKeys()` if desired. Cf. <#6312 (comment)>.
Cf. <#6311>.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)