Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kobo] Unbreak Wi-Fi on FW >= 4.23 #6522

Merged
merged 5 commits into from Aug 18, 2020
Merged

[Kobo] Unbreak Wi-Fi on FW >= 4.23 #6522

merged 5 commits into from Aug 18, 2020

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Aug 18, 2020 •
edited by Frenzie

Fix #6500

(I'm back! :)).

This change is Reviewable

@NiLuJe
Unbreak Wi-Fi on Kobo w/ FX >= 4.23+
3feaa26 
Stop relying on WIFI_MODULE_PATH, it's no longer exported by the init
script.

Fix koreader#6500
@NiLuJe
Resync the nickel restart script w/ upstream
142d348 
udev should be handling SD cards just fine. Plus, the FIFO is likely not
created yet at that point anyway...
@NiLuJe
Forgot shellcheck
b2a748c
@Frenzie Frenzie added this to the 2020.09 milestone Aug 18, 2020
@NiLuJe
Copy link
Member Author

NiLuJe commented Aug 18, 2020 •
edited

Haven't looked into the USBMS thingy I mentioned in #6500 yet.

Hopefully the random nickel.sh tweaks will help. In any case, I was already half of a mind to handle USBMS with a small external tool àla Cervantes anyway, so, eh.

Frenzie
Frenzie approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wb :-)

@NiLuJe
Fix Nickel FIFO race between nickel & udev
926b78e 
*sigh*

(One simple way to reproduce that is to restart nickel while plugged
in).
@NiLuJe
Copy link
Member Author

NiLuJe commented Aug 18, 2020

Okay, can't reproduce USBMS issues on the H2O with the latest tweaks.

I'll double-check on the Forma later ;).

@NiLuJe
Better comment
7c0c3fb 
Duh. We don't want to what udev writes in there before Nickel starts up to get lost in the ether.
That's probably why Nickel doesn't unlink, actually.
@NiLuJe
Copy link
Member Author

NiLuJe commented Aug 18, 2020

(This probably warrants a 08.1?)

@Frenzie
Copy link
Member

Frenzie commented Aug 18, 2020

Possibly slightly risky with #6521 just merged, but works for me. We'll just wait a couple of days.

@NiLuJe NiLuJe merged commit b14cabb into koreader:master Aug 18, 2020
@NiLuJe
Copy link
Member Author

NiLuJe commented Aug 19, 2020

Can't reproduce USBMS issues anymore on the Forma, either. Yay.

@Frenzie Frenzie modified the milestones: 2020.09, 2020.08.1 Aug 19, 2020
@poire-z
Copy link
Contributor

poire-z commented Aug 20, 2020

Just curious: did Kobo put back WIFI_MODULE_PATH with FW 4.23.15548 ? (meaning they would read around and care a little bit about the ecosystem - or not at all :)

@NiLuJe
Copy link
Member Author

NiLuJe commented Aug 20, 2020

Just curious: did Kobo put back WIFI_MODULE_PATH with FW 4.23.15548 ? (meaning they would read around and care a little bit about the ecosystem - or not at all :)

No ^^.

@NiLuJe
Copy link
Member Author

NiLuJe commented Aug 20, 2020

They did fix a minor annoyance I had with the DHCP setup when USBNet was enabled, though: http://trac.ak-team.com/trac/changeset/17720/niluje \o/

(Possibly as early as the original 4.23 release, I just stumbled on it today ;)).

@oldman63
Copy link

Kobo Aura H2O v1.0
Fw: 4.23.15505
KOReader 2020.08.1

WiFi problem after Sleeping KOReader is gone!
Thank you...

The Kobo Setup new Message: "Update Required!"
:-)

@Frenzie Frenzie added the Kobo label Aug 22, 2020
@welps welps mentioned this pull request Aug 26, 2020
Closed
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 17, 2020
@NiLuJe
Ensure the SD card is actually detected in Nickel on exit.
781db9a 
There's still a stupid popup being shown, but at least it works.

Regression since koreader#6522
@NiLuJe NiLuJe mentioned this pull request Oct 17, 2020
Merged
NiLuJe added a commit that referenced this pull request Oct 18, 2020
@NiLuJe
Ensure the SD card is actually detected in Nickel on exit. (#6800)
d9b6580 
* Ensure the SD card is actually detected in Nickel on exit.

Regression since #6522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees
No one assigned
Labels
Kobo
Projects
None yet
Milestone
2020.08.1
Development

Successfully merging this pull request may close these issues.

Wi-Fi not working after Kobo 4.23.15505 update.
4 participants
@NiLuJe @Frenzie @poire-z @oldman63