Update PocketBook device definitions #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd get rid of that one since it's not doing any good, but if I'm not mistaken hasColorScreen should be perfectly fine on any device. The only problem is that things would be rendered in 24-bit and subsequently downconverted to 8-bit. Which wastes memory and processing power but should otherwise be fine. |
Frenzie
reviewed
Aug 19, 2020
Another infamous roshavagarga typo fix. Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Possible fix for #6479.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Reasons:
Other:
Besides that, this is ready for review, can't test as always.
This change is