Make the manual rotation events useful #6530
Conversation
Restore a Swap event like before koreader#6309 Implement an Invert one And keep the fairly useless +90° CW one, but under an accurate name. Fix koreader#6524
|
(Untested as of yet, but the logic feels sound ;p). |
|
Yep, it works. Sidebar: Modifying a gesture only appears to take after a restart. Is it just me? Ping @yparitcher / @Frenzie |
not as far as i remember |
If it is a gestures issue, than switching between reader/FM reloads gestures like a restart, so you can use that to debug. |
I'll probably settle on |
That does work. Still puzzled why it doesn't take immediately, though. |
|
I think toggle's sensible enough. That's between portrait & landscape or reverse portrait & reverse landscape respectively, right? |
Yup! |
Can't reproduce, Is it with a specific gesture or a specific action? |
Randomly tested on a (FM) corner tap gesture with nothing/any of those rota ones. The initial switch from nothing to it is... weird. First tap rotates, then nada. Going from something to nothing doesn't exhibit the exact same weirdness (i.e., fully keeps the previous gesture until restart/reload). |
can confirm, when testing on the rotation one |
|
Does not happen in the reader :( |
when rotation was caused by a gesture the gesture settings were not flushed leading to weird state when the FM reinit reloaded the gestures plugin discovered in koreader#6530 caused by koreader#6309
should be fixed by #6532 |
Restore a Swap event like before #6309
Implement an Invert one
And keep the fairly useless +90° CW one, but under an accurate name.
Fix #6524
This change is