-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Kosync network callback" #6535
Conversation
This reverts commit d90e221.
Now that I'm back, remind me what was the issue that made you try this approach? |
@NiLuJe Kosync plugin doesn't adapt to your QoL wifi improvements, i.e. doesn't enable wifi when pushing/pulling progress and disabling it after. It just displays message along the lines of "Something went wrong, check your network" |
@Galunid: On which device? |
Ah, yeah, There's not really much we can do, as they may be called at a lot of weird moments, and, the rerunWhenOnline stuff will (as it should) always show the relevant UI bits. That said, on Kobo, with restore Wi-Fi on resume, it should behave properly in most cases, as it's frequent enough (I think?), that it should keep Wi-Fi alive. |
Frequent enough given an appropriate |
Yes, actually that's the reason I disabled koreader/plugins/kosync.koplugin/main.lua Lines 533 to 545 in 1b904f0
So if user called it, enable wifi, otherwise skip. |
Reverts #6489 since it introduced problems for people having
[*]Auto sync now and in the furture
&Action when wifi off: prompt
.This change is