Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full ToC entry on hold #6729

Merged
merged 15 commits into from Sep 30, 2020
Merged

Show full ToC entry on hold #6729

Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
22bf998
Show full ToC entry on hold
NiLuJe Sep 29, 2020
e70d4c0
Make it not-quite-fullscreen
NiLuJe Sep 29, 2020
588a0fe
Slightly less massive popup
NiLuJe Sep 29, 2020
30e5d53
Make LuaCheck happy
NiLuJe Sep 29, 2020
23e23b4
Better maths
NiLuJe Sep 29, 2020
f632d99
Get actual doc's language (thanks, @poire-z)
NiLuJe Sep 29, 2020
6e1d3f3
More usable popup height in Landscape
NiLuJe Sep 29, 2020
7c99750
Better title
NiLuJe Sep 29, 2020
2d5af0e
Disable justification
NiLuJe Sep 29, 2020
8cbb304
Switch to InfoMessage so we don't have to deal with size computations ;)
NiLuJe Sep 29, 2020
260e0e4
Trim toc_indent from the ToC popup
NiLuJe Sep 29, 2020
15d98e5
Get rid of trim-related code duplication
NiLuJe Sep 29, 2020
1da5270
Too many dashes!
NiLuJe Sep 29, 2020
764e26f
Better doc, maybe?
NiLuJe Sep 30, 2020
292b1c9
Migrate some other stuff to util.trim
NiLuJe Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions frontend/apps/reader/modules/readertoc.lua
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@ local GestureRange = require("ui/gesturerange")
local Geom = require("ui/geometry")
local InputContainer = require("ui/widget/container/inputcontainer")
local Menu = require("ui/widget/menu")
local TextViewer = require("ui/widget/textviewer")
local UIManager = require("ui/uimanager")
local logger = require("logger")
local _ = require("gettext")
Expand Down Expand Up @@ -582,6 +583,20 @@ function ReaderToc:onShowToc()
end
end

function toc_menu:onMenuHold(item)
print("toc_menu:onMenuHold", item)
print(require("dump")(item))
local textviewer = TextViewer:new{
title = _("ToC entry"),
NiLuJe marked this conversation as resolved.
Show resolved Hide resolved
text = item.text,
lang = nil, --- @todo: Get doc's lang?
NiLuJe marked this conversation as resolved.
Show resolved Hide resolved
width = math.floor(self.width * 0.8),
height = math.floor(self.height * 0.25),
}
UIManager:show(textviewer)
return true
end

toc_menu.close_callback = function()
UIManager:close(menu_container)
end
Expand Down