Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statistics: Don't blow up when annotating/highlighting stuff with the plugin loaded, but disabled #6829

Merged
merged 1 commit into from Oct 26, 2020
Merged

Statistics: Don't blow up when annotating/highlighting stuff with the plugin loaded, but disabled #6829

merged 1 commit into from Oct 26, 2020

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Oct 25, 2020 •
edited by Frenzie

Re #6825
Re #6827

This change is Reviewable

@NiLuJe
Copy link
Member Author

NiLuJe commented Oct 25, 2020

I also got rid of the inconsistent return true, because I guess we don't want to stop these events here?

(Although, currently, this is the sole bit of code handling those).

@NiLuJe
Copy link
Member Author

NiLuJe commented Oct 25, 2020 •
edited

The actual accurate count is computed properly in initData, which is done when enabling the plugin, so we don't really have to think about the whole lifecycle any more ;).

@NiLuJe NiLuJe added the bug label Oct 26, 2020
@NiLuJe NiLuJe added this to the 2020.11 milestone Oct 26, 2020
@NiLuJe NiLuJe added the Plugin label Oct 26, 2020
@NiLuJe NiLuJe merged commit 982702f into koreader:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poire-z poire-z poire-z approved these changes

Assignees
No one assigned
Labels
bug Plugin
Projects
None yet
Milestone
2020.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NiLuJe @poire-z