Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: CSS and image sizing fixes and tweaks #7235

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

poire-z
Copy link
Contributor

@poire-z poire-z commented Feb 3, 2021

Includes:


This change is Reviewable

Includes:
- CSS: add units vw vh vmin vmax
- CSS max-height: apply to block elements
- 2-pages mode/1-page number: fix title/author alternation
- EPUB: fix segfault on missing items in opf manifest
- (Upstream) CacheFileHeader: zero the alignment padding for reproducibility
- (Upstream) CSS: parse_number_value(): round to nearest
- getStyledImageSize(): tweak min/max-width/height computations
- getStyledImageSize(): don't ignore FB2/SVG <image> element
- getStyledImageSize(): hack to handle sizing via SVG wrappers
@poire-z poire-z added this to the 2021.02 milestone Feb 3, 2021
@poire-z poire-z merged commit a43da51 into koreader:master Feb 3, 2021
@poire-z poire-z deleted the bump_crengine branch February 3, 2021 20:31
@ptrm
Copy link
Contributor

ptrm commented Feb 4, 2021

Great! Would this mean that width: 300%; in my dictionary's css should work as well? I recently discovered how to display images using lua text substitution, but had to manually upscale them to fit my needs. The css I above does not seem to work still even with the nightly, but maybe it's just the unit or something that simple?

@poire-z
Copy link
Contributor Author

poire-z commented Feb 4, 2021

Nope, the dictionary HTML results are not rendered by crengine, but by MuPDF (fortunately, for me :).
So, you should look at CSS support in MuPDF for what you can do (we lag, and koreader/koreader-base#1203 is paused :()

@ptrm
Copy link
Contributor

ptrm commented Feb 4, 2021

That explains a lot, thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank title page - Cover is not displayed
2 participants