A few UI fixes #7322
Merged
A few UI fixes #7322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the dim state isn't updated properly, because Button trusts the state flag. Regression since koreader@6132e8c Fix koreader#7317
ScrollTextWidget Despite a similar API between ScrollTextWidget and ScrollHtmlWiget, what they do internally doesn't quite match. So, while ScrollHtmlWidget's resetSCroll *does* rewind back to the top, ScrollTextWidget's doesn't, it just updates the scrollbar itself. So, do that on our end, *before* the (re-)init, which'll call _renderText for us. Fix koreader#7318
blanks if necessary in order to get a consistent alignment. Fix koreader#7316
|
(Rebase me). |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7316, #7317, #7318
This change is