OPDS: Don't needlessly setup Basic auth #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That causes us to try Basic auth, which is useless (and may or may not be problematic for some servers).
Some servers may still refuse to obey, though. They're breaking RFC2616 by doing so.
Maybe some workarounds especially for this server? |
|
PRs welcome to handle But that server is hella broken. (e.g., it does send a |
It already handles setting up the Host & Basic authentication headers
|
On that server I cannot even get the books list, OPDS browser gives a message 'Catalog not found'. |
|
Yep, because it's serving gzip data instead of plaintext ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputDialog returns empty strings, not nil. Explicitly nil username
& passwordwhen they're empty to avoid enabling authentication.Also, re #7370, explicitly request no compression. Doesn't fix the actual issue because the server doesn't obey, breaking the RFC. Most servers were already assuming no Accept-Encoding header meant that we really didn't want gzip data ;p.
This change is