InputDialog: manage hiding the keyboard #7908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poire-z
reviewed
Jun 29, 2021
frontend/ui/widget/inputdialog.lua
Outdated
| @@ -466,7 +467,7 @@ function InputDialog:init() | |||
| end | |||
|
|
|||
| function InputDialog:onTap() | |||
| if self.fullscreen or self.add_nav_bar then | |||
| if self.deny_keyboard_hiding or self.fullscreen or self.add_nav_bar then | |||
There was a problem hiding this comment.
To avoid having to do 3 checks here, you could have in InputDialog:init():
if self.fullscreen or self.add_nav_bar then
self.deny_keyboard_hiding = true
end
poire-z
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New property to allow/deny hiding the keyboard with the tap outside of the dialog.
Useful in Text editor
FindandGodialogs (and maybe somewhere else, where hiding the keyboard is undesirable).This change is