Bengali Probhat layout #8887

uroybd · 2022-03-10T09:25:29Z

This PR contains codes for a popular Bengali keyboard layout named Probhat.

However, I don't really know how to register this in the app to be able to use this.

This change is

Frenzie · 2022-03-10T09:39:34Z

We'll have a look, but I don't have time to right now. :-)

poire-z · 2022-03-10T09:39:36Z

Just curious: do you get all your bengali glyphs displayed correctly?
From which of our shipped fonts do they come ?
Noto Sans Devanagari ? https://fonts.google.com/noto/specimen/Noto+Sans+Devanagari does not mention Bengali among its supported languages (if it is a language, might just be a script, not familiar at all with all those indic scripts&languages :).
Or from our FreeSans or FreeSerif, which has support for many scripts ? (but with possibly smaller/thiner glyphs).

uroybd · 2022-03-10T09:44:44Z

Just curious: do you get all your bengali glyphs displayed correctly? From which of our shipped fonts do they come ? Noto Sans Devanagari ? https://fonts.google.com/noto/specimen/Noto+Sans+Devanagari does not mention Bengali among its supported languages (if it is a language, might just be a script, not familiar at all with all those indic scripts&languages :). Or from our FreeSans or FreeSerif, which has support for many scripts ? (but with possibly smaller/thiner glyphs).

No, Noto Sans Bengali is the font we need: https://fonts.google.com/noto/specimen/Noto+Sans+Bengali
It is standard in Android system for a long time though.

uroybd · 2022-03-10T09:46:22Z

Should I add Noto Sans Bengali In the fallback fonts?

mergen3107 · 2022-03-10T09:51:32Z

@uroybd
Welcome to the KOReader Keyboard Tinkering Club® :D

From your question thread:
What if I need more keys in the 3rd row?:
You can just add new keys as strings in table (a table starts with a single { and ends with its own },), but make sure to adjust the widths of other rows if necessary. For example have a look at Turkish layout.

Should I add Noto Sans Bengali In the fallback fonts?

Probably yes, because KOReader is supported not only on Androids.

poire-z · 2022-03-10T10:05:15Z

Should I add Noto Sans Bengali In the fallback fonts?

Not yet.
You might have it on Android, but we won't have it on Kobo/Kindle/etc...
So, we might need to add the font itself to those shipped with KOReader.

But testing, it looks to me like we have support for Bengali in both FreeSans and FreeSerif:
FreeSans (used before FreeSerif, so you should get these glyphs on your keyboard):

FreeSerif:

So, that means your keyboard should at least show some stuff on Kobo and Kindle.

The question is: is that good looking and complete enough ?
(Shipping new fonts is not fun (needs some work), and increase the package size - so it depends on the user base - which I guess is quite huge for Bengali :)

uroybd · 2022-03-10T10:09:38Z

The question is: is that good looking and complete enough ? (Shipping new fonts is not fun (needs some work), and increase the package size - so it depends on the user base - which I guess is quite huge for Bengali :)

Bengali speakers are virtually everywhere, tropical reproduction is to be blamed. ;)

I've added a PR to add font in the font repo koreader/koreader-fonts#16

poire-z · 2022-03-10T10:13:09Z

You haven't answered if the FreeSans/FreeSerif are good enough or not.
We mostly add the fonts themselves when we have a UI language that needs it. For your case, your keyboard could be fine with just our FreeSans.
So, please convince us that shipping NotoSansBengali is really needed :)

(We have a Hebrew UI language, and we don't even ship a Hebrew font - FreeSans or FreeSerif seems fine enough.)

uroybd · 2022-03-10T10:23:54Z

You haven't answered if the FreeSans/FreeSerif are good enough or not. We mostly add the fonts themselves when we have a UI language that needs it. For your case, your keyboard could be fine with just our FreeSans. So, please convince us that shipping NotoSansBengali is really needed :)

Sorry, missed that. It is not good enough. Bengali has a complex rendering system. In your examples, many conjunction glyphs are not rendering properly. I'm adding an example to show how it should be using a proper font:

The rendering is not a system issue for kindle or kobo because I've seen users using these devices to read Bengali. So I believe, with proper fonts everything will be fine.

poire-z · 2022-03-10T11:13:43Z

Btw, since #8722, if a user drops (or already has) a Noto Sans Bengali UI font in there, it will be automatically used as a fallback font.
So, shipping or not this font is a bit orthogonal to your keyboard.
We didn't ship any font for Myanmar, we just allowed users to help themselves.
Bengali user base is probably larger, so I let @NiLuJe & @Frenzie the last word on shipping or not the one you added in koreader/koreader-fonts#16.

Frenzie · 2022-03-10T11:37:47Z

I don't really recall the discussion around Myanmar but some 180 kB isn't the worst. That being said also compare that abandoned PR @pazos did a while back.

uroybd · 2022-03-10T12:01:08Z

Btw, since #8722, if a user drops (or already has) a Noto Sans Bengali UI font in there, it will be automatically used as a fallback font.
So, shipping or not this font is a bit orthogonal to your keyboard.
We didn't ship any font for Myanmar, we just allowed users to help themselves.
Bengali user base is probably larger, so I let @NiLuJe & @Frenzie the last word on shipping or not the one you added in koreader/koreader-fonts#16.

Shipping this font is not an absolute necessity. We have seen that the FreeSans and FreeSerif already provide the glyphs. We don't use complex Conjunction glyphs on the keyboard. They get generated automatically by the font. So, we don't need Noto Sans Bengali for the keyboard itself.

However, considering the userbase and file size, you can add this font. Like Devanagari, Bengali script is also being used by Asaamia and some other languages.

NiLuJe · 2022-03-10T12:18:21Z

Yeah, Bengali probably makes sense, especially given the potential user base ;).

1. Fixed bug that was force closing the keyboard. 2. Fixed key sizes. 3. Added appropriate alt label. 4. Rename Locale label for 'bn' from 'বাঙালি' to 'বাংলা'.

uroybd · 2022-03-14T11:36:50Z

I've setup a dev environment and fixed all the bugs related to this PR. Tested it for some hours. Everything seems to be fine. Tweaked the key sizes and alt labels.

uroybd · 2022-03-15T13:28:41Z

Is there anything else I can do before you can merge this?

poire-z · 2022-03-15T13:46:02Z

Bump the koreader-fonts submodule, in this PR as it is quite related :)

uroybd · 2022-03-15T13:50:34Z

Bump the koreader-fonts submodule, in this PR as it is quite related :)

Done. :)

poire-z · 2022-03-15T13:56:14Z

Something yet to fix to avoid CI failures on later unrelated PRs:

Luacheck results
Checking frontend/ui/data/keyboardlayouts/bn_keyboard.lua 1 warning

    frontend/ui/data/keyboardlayouts/bn_keyboard.lua:138:7: unused variable 'zwj'

Total: 1 warning / 0 errors in 485 files

uroybd · 2022-03-15T14:06:32Z

Should I Squash these commits for cleanliness?

poire-z · 2022-03-15T14:16:20Z

Should I Squash these commits for cleanliness?

We will squash them when merging, so no need for you to do it (and we keep the history of the work in there with the individual commits). Unless you prefer to have more than one commit in what we merge if you think they deserved to be multiple individual unrelated ones ?

Still an issue with CI:

[ RUN      ] spec/front/unit/document_spec.lua @ 73: EPUB document module should register droid sans fallback
spec/front/unit/document_spec.lua:87: Expected objects to be the same.
Passed in:
(table: 0x7f00df4e4560) {
  [1] = 'Droid Sans Mono'
  [2] = 'FreeSans'
  [3] = 'FreeSerif'
  [4] = 'Noto Naskh Arabic'
  [5] = 'Noto Sans'
  [6] = 'Noto Sans Arabic UI'
 *[7] = 'Noto Sans Bengali UI'
  [8] = 'Noto Sans CJK SC'
  [9] = 'Noto Sans Devanagari UI'
  [10] = 'Noto Serif' }
Expected:
(table: 0x7f00df4d7b58) {
  [1] = 'Droid Sans Mono'
  [2] = 'FreeSans'
  [3] = 'FreeSerif'
  [4] = 'Noto Naskh Arabic'
  [5] = 'Noto Sans'
  [6] = 'Noto Sans Arabic UI'
 *[7] = 'Noto Sans CJK SC'
  [8] = 'Noto Sans Devanagari UI'
  [9] = 'Noto Sans Bengali UI'
  [10] = 'Noto Serif' }

stack traceback:
	spec/front/unit/document_spec.lua:87: in function <spec/front/unit/document_spec.lua:73>

[  FAILED  ] spec/front/unit/document_spec.lua @ 73: EPUB document module should register droid sans fallback (0.27 ms)

(Looks like there's some kind of alphabetical ordering somewhere, and you added Bengali after Devanagari like you did good in other places - but it should be before somewhere in there :)

uroybd · 2022-03-15T14:29:16Z

Fixed the font ordering. :)

poire-z · 2022-03-15T14:38:53Z

You changed more places than were needed (it was only need in spec/, for the test itself).

Dunno the differences in the amount of readers and content for Devanagari vs. Bengali, and which deserves to be first in the various lists. (If in doubt, let Bengali be polite and place itself after long-time-there Devangari :)
There's one place where you didn't change the order, frontend/ui/font.lua, where Devanagari is still before Bengali.

uroybd · 2022-03-15T14:58:26Z

I intended to do this in alphabetical order. I personally have no problem having Bengali after Devanagari.

I've added Bengali after Devanagari in all Lua files for consistency this time.

uroybd · 2022-03-15T15:08:12Z

spec/front/unit/document_spec.lua:87: Expected objects to be the same.
Passed in:
(table: 0x7f6a80ebc6e8) {
  [1] = 'Droid Sans Mono'
  [2] = 'FreeSans'
  [3] = 'FreeSerif'
  [4] = 'Noto Naskh Arabic'
  [5] = 'Noto Sans'
  [6] = 'Noto Sans Arabic UI'
 *[7] = 'Noto Sans Bengali UI'
  [8] = 'Noto Sans CJK SC'
  [9] = 'Noto Sans Devanagari UI'
  [10] = 'Noto Serif' }
Expected:
(table: 0x7f6a80ed3508) {
  [1] = 'Droid Sans Mono'
  [2] = 'FreeSans'
  [3] = 'FreeSerif'
  [4] = 'Noto Naskh Arabic'
  [5] = 'Noto Sans'
  [6] = 'Noto Sans Arabic UI'
 *[7] = 'Noto Sans CJK SC'
  [8] = 'Noto Sans Devanagari UI'
  [9] = 'Noto Sans Bengali UI'
  [10] = 'Noto Serif' }

stack traceback:
	spec/front/unit/document_spec.lua:87: in function <spec/front/unit/document_spec.lua:73>

Now, this is weird. I've searched the codebase. Nowhere is Noto Sans Bengali UI except after Noto Sans Devanagari UI. Am I missing something?

spec/unit/document_spec.lua

Bengali Probhat layout

1b56176

Frenzie added this to the 2022.03 milestone Mar 10, 2022

uroybd mentioned this pull request Mar 10, 2022

Noto Sans Bengali UI for Bengali support koreader/koreader-fonts#16

Merged

added font fallback for Noto Sans Bengali UI

c64175f

Bugfixes and Enhancments.

eeba754

1. Fixed bug that was force closing the keyboard. 2. Fixed key sizes. 3. Added appropriate alt label. 4. Rename Locale label for 'bn' from 'বাঙালি' to 'বাংলা'.

uroybd added 2 commits March 14, 2022 18:02

added some less-used symbols

a36def4

optimized key width for Bengali Probhat

ffb3b0d

bumped koreader-font submodule

f7cc68a

removed unused import

d89bee6

fixed font orders

da2175b

fixed font ordering consistency

903d118

poire-z reviewed Mar 15, 2022

View reviewed changes

spec/unit/document_spec.lua Outdated Show resolved Hide resolved

fixed font ordering

7a08a3b

poire-z approved these changes Mar 15, 2022

View reviewed changes

poire-z merged commit 357bc65 into koreader:master Mar 15, 2022

Frenzie mentioned this pull request Mar 17, 2022

FR: Bengali Keyboard Layout #8883

Closed

Frenzie linked an issue Mar 17, 2022 that may be closed by this pull request

FR: Bengali Keyboard Layout #8883

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bengali Probhat layout #8887

Bengali Probhat layout #8887

uroybd commented Mar 10, 2022 •

edited by Frenzie

Frenzie commented Mar 10, 2022

poire-z commented Mar 10, 2022

uroybd commented Mar 10, 2022

uroybd commented Mar 10, 2022

mergen3107 commented Mar 10, 2022

poire-z commented Mar 10, 2022

uroybd commented Mar 10, 2022

poire-z commented Mar 10, 2022 •

edited

uroybd commented Mar 10, 2022

poire-z commented Mar 10, 2022

Frenzie commented Mar 10, 2022

uroybd commented Mar 10, 2022

NiLuJe commented Mar 10, 2022

uroybd commented Mar 14, 2022

uroybd commented Mar 15, 2022

poire-z commented Mar 15, 2022

uroybd commented Mar 15, 2022

poire-z commented Mar 15, 2022

uroybd commented Mar 15, 2022

poire-z commented Mar 15, 2022

uroybd commented Mar 15, 2022

poire-z commented Mar 15, 2022 •

edited

uroybd commented Mar 15, 2022 •

edited

uroybd commented Mar 15, 2022

Bengali Probhat layout #8887

Bengali Probhat layout #8887

Conversation

uroybd commented Mar 10, 2022 • edited by Frenzie

Frenzie commented Mar 10, 2022

poire-z commented Mar 10, 2022

uroybd commented Mar 10, 2022

uroybd commented Mar 10, 2022

mergen3107 commented Mar 10, 2022

poire-z commented Mar 10, 2022

uroybd commented Mar 10, 2022

poire-z commented Mar 10, 2022 • edited

uroybd commented Mar 10, 2022

poire-z commented Mar 10, 2022

Frenzie commented Mar 10, 2022

uroybd commented Mar 10, 2022

NiLuJe commented Mar 10, 2022

uroybd commented Mar 14, 2022

uroybd commented Mar 15, 2022

poire-z commented Mar 15, 2022

uroybd commented Mar 15, 2022

poire-z commented Mar 15, 2022

uroybd commented Mar 15, 2022

poire-z commented Mar 15, 2022

uroybd commented Mar 15, 2022

poire-z commented Mar 15, 2022 • edited

uroybd commented Mar 15, 2022 • edited

uroybd commented Mar 15, 2022

uroybd commented Mar 10, 2022 •

edited by Frenzie

poire-z commented Mar 10, 2022 •

edited

poire-z commented Mar 15, 2022 •

edited

uroybd commented Mar 15, 2022 •

edited