[plugin] Wallabag: abort synchronisation on request error #8950
Conversation
plugins/wallabag.koplugin/main.lua
Outdated
| @@ -430,6 +430,12 @@ function Wallabag:getArticleList() | |||
| .. filtering | |||
| local articles_json = self:callAPI("GET", articles_url, nil, "", "", true) | |||
|
|
|||
| if articles_json == false then | |||
There was a problem hiding this comment.
This logic can't be right. ;-) This is identical to replacing the break a few lines down with return.
I haven't had the time to look at it, but the most typical idiom is probably to pass a reason along.
For example, at its simplest:
false, "connection error"While if it's an HTTP error code, maybe
false, "http", statusIn any case, the problem is that a "proper" error is conflated with another type. Conflating them the other way around would retain that problem.
There was a problem hiding this comment.
Thanks, I didn't see initially that non-200 http responses were also returning false instead of nil. Errors are handled when retrieving entries now. Error handling for minor actions (adding tags, adding/removing articles) is not implemented yet.
… on request error Fixes <koreader#8949>.
|
I tested some scenarios that would trigger a network_error. I have been using this patch for the past two weeks without noticing any other issues. |
Fixes #8949. Not tested yet.
This change is