-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to MultiInputDialog to return input fields #9484
Conversation
In order to update the field's text value after it's been rendered, the input field needs to be returned, and not just the text value.
Not familiar with the widget, but wouldn't it make more sense to make those fugly-ass module-locals you're trying to access instance members, and just use a getter method? |
Do you mean like, make In context, this is how I'm using the new method. dialog:getInputFields()[2]:setText(path) It seems weird to me that the getFields method doesn't return the widgets to begin with. Oh well. |
I want to raise the question to the use case here too. If there is no use case, it is dead code. |
Use case is the Newsdownloader replacement, again. I might be able to avoid having to use this patch, though... and might retract this :) |
Ok! I do want this :) @NiLuJe how are you suggesting I revise the code? Make |
Unless there was a technical reason for the weird module local, yep! |
Also, supersedes koreader#9484
Also, supersedes koreader#9484
Superseded by #9586 ( |
In order to update the field's text value after it's been rendered, the input field needs to be returned, and not just the text value.
This change is