Fix broken translation metadata #9726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix koreader#9719 Regression introduced in koreader#9682 by my fault. See the xgettext error message: ``` frontend/dispatcher.lua:573: warning: Empty msgid. It is reserved by GNU gettext: gettext("") returns the header entry with meta information, not the empty string. xgettext: warning: msgid '' is used without plural and with plural. xgettext.c:1975: Here is the occurrence without plural. frontend/dispatcher.lua:573: Here is the occurrence with plural. Workaround: If the msgid is a sentence, change the wording of the sentence; otherwise, use contexts for disambiguation. ```
Frenzie
commented
Nov 1, 2022
| @@ -570,7 +570,7 @@ function Dispatcher:menuTextFunc(settings) | |||
| if item == "settings" then item = next(settings, item) end | |||
| action_name = Dispatcher:getNameFromItem(item, settings) | |||
| else | |||
| action_name = T(N_("", "%1 actions", count), count) | |||
| action_name = T(NC_("Dispatcher", "", "%1 actions", count), count) | |||
There was a problem hiding this comment.
This isn't really right either since the singular is used as the ID, but it might work as long as there's only one per context.
Requires some more thought but I'll merge this quickly to fix the plurals.
There was a problem hiding this comment.
It seems that english singular is missing in weblate.
There was a problem hiding this comment.
Given all the tools expect it plus resulting confusion it'll be best to put an unused singular in there.
The "problem" is that if there's only one action, the name of the action is shown. It only says 2 actions, 3 actions, etc. if there's more than 1.
Frenzie
added a commit
that referenced
this pull request
Nov 2, 2022
Tools and humans alike are confused by leaving it empty. It should be inoffensive to resolve the problem this by having an unused singular. Doing anything else would make it so we couldn't have the correct plurals in Slovak, among others. Follow-up to #9726
Frenzie
added a commit
that referenced
this pull request
Nov 3, 2022
Tools and humans alike are confused by leaving it empty. It should be inoffensive to resolve the problem this by having an unused singular. Doing anything else would make it so we couldn't have the correct plurals in Slovak, among others. Follow-up to #9726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #9719
Regression introduced in #9682 by my fault.
See the xgettext error message:
This change is