Reader style tweaks: register in Dispatcher manually #9816
Conversation
|
You will solve https://www.mobileread.com/forums/showthread.php?p=4274863#post4274863 :) (to which I would have replied "yes, wrong tool for the job", but ok, no other tool available, so the one you just made will have to do). |
|
Also some discussion in #8590 (comment). |
| text = self.is_tweak_registered and _("Don't show in action list") or _("Show in action list"), | ||
| callback = function() | ||
| self.toggle_tweak_registered_callback() |
There was a problem hiding this comment.
The wording "tweak registered" in this pure styletweaks context is a bit confusing - I would mention "dispatcher" in the variables/settings/methods, ie. is_dispatcher_registered.
There was a problem hiding this comment.
It corresponds with self.registered_tweaks and style_tweaks_registered G_setting.
There was a problem hiding this comment.
Yes, I saw that. But even style_tweaks_registered is a bit anonymous when just viewing the settings. If style_tweaks_dispatcher_registered is too long, just seeing "dispatcher" is better than "registered" (into what?). style_tweaks_dispatcher ? style_tweaks_in_dispatcher ? so-so :/
registered sounds too alike enabled when just studying this readerstyletweak.lua module.
There was a problem hiding this comment.
Feels like style_tweaks_in_dispatcher, is_tweak_in_dispatcher, self.tweaks_in_dispatcher would read well.
If you really feel like sticking with "..._registered", please add some comment where this thing is created/read/saved, -- registered in dispatcher, so we don't have to follow it all the way to where it is neighboured by dispatcherRegisterStyleTweak() to know it is actually in Dispatcher that it is registered :)
There was a problem hiding this comment.
I'm not stuck, just have no good idea. Let it be "in_dispatcher".
| {category="none", event="ToggleStyleTweak", arg=tweak_id, title=T(_("Toggle style tweak: %1"), tweak_title), rolling=true}) | ||
| end | ||
|
|
||
| local function dispatcherRemoveStyleTweak(tweak_id) |
There was a problem hiding this comment.
Wording only again: do we use Register/Remove elsewhere ? I would expect Register/Unregister.
There was a problem hiding this comment.
koreader/plugins/profiles.koplugin/main.lua
Lines 57 to 64 in 486d707
There was a problem hiding this comment.
Didn't notice that at the time (or I was less interested by the profile plugin than by this styletweak module :).
I'd prefer to read all (these 2 only then?) as register/unregister - but up to you.
| self.ui.doc_settings:saveSetting("book_style_tweak", self.book_style_tweak) | ||
| self.ui.doc_settings:saveSetting("book_style_tweak_enabled", self.book_style_tweak_enabled) | ||
| self.ui.doc_settings:saveSetting("book_style_tweak_last_edit_pos", self.book_style_tweak_last_edit_pos) | ||
| end | ||
|
|
||
| local function dispatcherRegisterStyleTweak(tweak_id, tweak_title) | ||
| Dispatcher:registerAction("style_tweak_"..tweak_id, | ||
| {category="none", event="ToggleStyleTweak", arg=tweak_id, title=T(_("Toggle style tweak: %1"), tweak_title), rolling=true}) |
There was a problem hiding this comment.
Dunno if that's possible (or if all user-added settings and styletweaks are just non-contextualized stuff for Dispatcher), but seeing your screenshot, a separator between previous and all styletweaks would be nice.
Style tweaks can be applied with a gesture or added to a profile.
This change is