TouchMenu: menu search without patterns #9884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poire-z
reviewed
Dec 7, 2022
frontend/ui/widget/touchmenu.lua
Outdated
Comment on lines
1322
to
1324
| local status, err = pcall( function() ("test_string"):find(search_for) end) | ||
| local status, err = pcall( function() ("test_string"):find(search_for, 1, true) end) | ||
| if status then | ||
| search_for = Utf8Proc.lowercase(search_for) |
There was a problem hiding this comment.
I think this pcall was actually to test that the input string, if it is a Lua pattern, is a valid pattern, and show "Malformed message" if it is not (if Lua :find() fails using it).
If we don't do pattern find, no need for the pcall and the else branch, right ?
Frenzie
commented
Dec 7, 2022
| else | ||
| err = err:sub(err:find("lua") + 10) -- 10 = strlen("lua:1165: ") | ||
| UIManager:show(InfoMessage:new{ | ||
| text = T(_("Malformed message:\n%1"), err) |
There was a problem hiding this comment.
Also I'd overlooked this one; hopefully the translators haven't noticed it yet. :-)
poire-z
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9876 (comment).
This change is