Spin off hms as selectable time format #9924

melyux · 2022-12-16T12:49:30Z

The bare minimum changes to do this as talked about in that other PR. Mostly updating datetime.secondsToClockDuration() usages. Updated tests

The name of the hms option is up for debate. "Literal" is the stand-in

This change is

NiLuJe · 2022-12-16T17:24:50Z

"Literal" is the stand-in

How about... hear me... "hms"? :D

EDIT: Except l10n is going to piss on my parade on that one, nevermind :/.

NiLuJe · 2022-12-16T17:29:12Z

Looks fine at a quick glance (all the changes from modern seem to make sense, AFAICT).

poire-z · 2022-12-17T23:34:27Z

Good to go ?

poire-z · 2022-12-30T13:27:38Z

So, all good ? I trust @melyux about the code changes and expected display results - @Frenzie : ok with the translation tweaks ?

Frenzie · 2022-12-30T19:01:55Z

What was literal again? I recall wanting to think about something better.

melyux · 2022-12-30T19:11:35Z

I think one of us suggested it in the other discussion, which may or may not have been a joke ("littoral" was it?). I like it cuz it's literal without using symbols. Or maybe it was meant to be "letter-al" because it uses letters... that's nice. So maybe we could call it "Letters"

My first thought "hms" is not very translation friendly, even tho seems to be what people call it if they ever call it anything. Doesn't matter that much since we give an example next to it

poire-z · 2022-12-30T19:30:33Z

that must have been me, littéral in french translates to literal in english :/
So, that's what I meant, literal, as plain, obvious, reading as written.

Frenzie · 2022-12-30T20:31:45Z

My first thought "hms" is not very translation friendly, even tho seems to be what people call it if they ever call it anything. Doesn't matter that much since we give an example next to it

Why do you say it's not?

melyux · 2022-12-30T21:41:34Z

I guess it could be. The letters themselves are translatable after all. Do you prefer "Letters" or "HMS"?

Frenzie · 2022-12-30T21:57:17Z

Is there any particular reason to try to avoid hours minutes seconds?

melyux · 2022-12-30T22:06:14Z

Seems out of the pithy theme of "Classic" and "Modern" :)

poire-z · 2023-01-01T19:08:35Z

So, all good (bis) ?

Frenzie · 2023-01-01T20:38:32Z

Well, there's a lack of screenshots and I don't really want to fetch it, so I have no idea one way or the other.

melyux · 2023-01-03T17:44:06Z

Where did we land on the exact wording instead of "Literal"?

Frenzie · 2023-01-03T18:13:30Z

Please provide some screenshots to figure that out. ;-)

NiLuJe · 2023-02-02T20:11:15Z

Gentle ping ;).

Frenzie · 2023-02-02T20:46:50Z

I guess this would be the relevant screenshot?

As I seem to have said previously, I'd probably just call that HMS with a translator's note (or Letters). But I'd have no idea what literal means if someone said it.

poire-z · 2023-02-02T20:50:41Z

But I'd have no idea what literal means if someone said it.

I said it, but I won't stand for it :):

that must have been me, littéral in french translates to literal in english :/
So, that's what I meant, literal, as plain, obvious, reading as written.

Frenzie · 2023-02-02T21:25:43Z

as written

"Written" might be a decent alternative.

NiLuJe · 2023-02-02T21:46:16Z

"Spelled out"?

Frenzie · 2023-02-02T21:48:16Z

That makes me think it's currently twenty-two forty-seven o'clock.

NiLuJe · 2023-02-02T21:49:35Z

True enough ;o).

melyux · 2023-02-02T21:59:19Z

I like "Written" too. Actually wait, I saw the "Letters" suggestion, and I like that even better

Frenzie · 2023-02-03T09:39:57Z

Letters and Written are both fine by me. Letters then?

melyux · 2023-02-04T06:18:24Z

Pushed

Frenzie · 2023-02-13T10:21:03Z

plugins/statistics.koplugin/main.lua

@@ -1872,7 +1872,7 @@ function ReaderStatistics:getDatesFromAll(sdays, ptype, book_mode)
            local stop_month = os.time{year=year_end, month=month_end, day=1, hour=0, min=0 }
            table.insert(results, {
                date_text,
-                T(N_("%1 (%2 page)", "%1 (%2 pages)", tonumber(result_book[2][i])), datetime.secondsToClockDuration(user_duration_format, tonumber(result_book[3][i]), false, true), tonumber(result_book[2][i])),
+                T(N_("%1 (%2 page)", "%1 (%2 pages)", tonumber(result_book[2][i])), datetime.secondsToClockDuration(user_duration_format, tonumber(result_book[3][i]), false), tonumber(result_book[2][i])),


What exactly is this saying? Is the first meant to be %1 (1 page)?

I think a mistake from when the workings of gettext were a mystery, a mystery compounded by the order of the variables, left over from the statistics PR. It should say this, I think:

T(N_("%2 (1 page)", "%2 (%1 pages)", tonumber(result_book[2][i])), datetime.secondsToClockDuration(user_duration_format, tonumber(result_book[3][i]), false), tonumber(result_book[2][i])),

Would you mind fixing it in a mini-PR if your mind's still in tune with this code?

No problem, but as a sanity check, is the corrected line I posted actually correct? The gettext part

Not entirely, always write it sensibly, i.e., it should look like "%1 (1 page)", "%1 (%2 pages)".

It's the code that should adapt, not what's given to the translators. ^_^

I always always forget that the N_() does nothing except choose one of the strings depending on the number given in the second arg

poire-z · 2023-02-17T19:54:49Z

Btw, wouldn't you prefer your letters'ed duration to get a little spacing ?
Tried it, and 1d23h38m may feel a bit crowded.
I just noticed that in some private patched feature of mine, I output it as 1d 23h 38m with regular spaces.
Could look in-between these with thin/hair spaces ? Unless the usage is to see all that stuck ? (And may be it's a french thing to add space everywhere like before a question mark :)

melyux · 2023-02-17T22:10:16Z

@poire-z I made the exact same patch for myself, with the added spaces! But didn't think you guys would like it. I think it looks better with the spaces, no hairline required. I'm down to do a mini PR to add the space if everyone else is fine with it too

NiLuJe · 2023-02-17T22:12:05Z

No objection here ;).

@Frenzie

Fix some of my early blunders in using the `N_()` gettext function. Mini-PR from #9924 (comment) (@Frenzie). There was also one line for generating this same `%1 (%2 pages)` text that confusingly uses different ordering in the SQL query output; switched the two SELECT arguments around to make it match the other 5 usages. Works the same as before

Spin off hms as selectable time format

dafc9e9

melyux force-pushed the hms-as-separate-format branch from ba0e055 to dafc9e9 Compare December 16, 2022 12:51

Frenzie added this to the 2022.12 milestone Dec 18, 2022

poire-z modified the milestones: 2023.01, 2023.02 Jan 23, 2023

Rename 'literal' to 'letters'

8112238

Frenzie approved these changes Feb 4, 2023

View reviewed changes

poire-z merged commit 8b99c50 into koreader:master Feb 12, 2023

Frenzie reviewed Feb 13, 2023

View reviewed changes

This was referenced Feb 19, 2023

Add spaces to Letters time format when non-compact, remove lead 0s #10141

Merged

ReadingStats: Fix N_() usages, rearrange a SQL select #10146

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spin off hms as selectable time format #9924

Spin off hms as selectable time format #9924

melyux commented Dec 16, 2022 •

edited by Frenzie

Loading

NiLuJe commented Dec 16, 2022 •

edited

Loading

NiLuJe commented Dec 16, 2022

poire-z commented Dec 17, 2022

poire-z commented Dec 30, 2022

Frenzie commented Dec 30, 2022

melyux commented Dec 30, 2022 •

edited

Loading

poire-z commented Dec 30, 2022

Frenzie commented Dec 30, 2022

melyux commented Dec 30, 2022 •

edited

Loading

Frenzie commented Dec 30, 2022

melyux commented Dec 30, 2022

poire-z commented Jan 1, 2023

Frenzie commented Jan 1, 2023

melyux commented Jan 3, 2023

Frenzie commented Jan 3, 2023

NiLuJe commented Feb 2, 2023

Frenzie commented Feb 2, 2023

poire-z commented Feb 2, 2023

Frenzie commented Feb 2, 2023

NiLuJe commented Feb 2, 2023

Frenzie commented Feb 2, 2023

NiLuJe commented Feb 2, 2023

melyux commented Feb 2, 2023 •

edited

Loading

Frenzie commented Feb 3, 2023

melyux commented Feb 4, 2023

Frenzie Feb 13, 2023

melyux Feb 13, 2023 •

edited

Loading

Frenzie Feb 13, 2023

melyux Feb 13, 2023 •

edited

Loading

Frenzie Feb 13, 2023

melyux Feb 14, 2023

poire-z commented Feb 17, 2023

melyux commented Feb 17, 2023

NiLuJe commented Feb 17, 2023

Spin off hms as selectable time format #9924

Spin off hms as selectable time format #9924

Conversation

melyux commented Dec 16, 2022 • edited by Frenzie Loading

NiLuJe commented Dec 16, 2022 • edited Loading

NiLuJe commented Dec 16, 2022

poire-z commented Dec 17, 2022

poire-z commented Dec 30, 2022

Frenzie commented Dec 30, 2022

melyux commented Dec 30, 2022 • edited Loading

poire-z commented Dec 30, 2022

Frenzie commented Dec 30, 2022

melyux commented Dec 30, 2022 • edited Loading

Frenzie commented Dec 30, 2022

melyux commented Dec 30, 2022

poire-z commented Jan 1, 2023

Frenzie commented Jan 1, 2023

melyux commented Jan 3, 2023

Frenzie commented Jan 3, 2023

NiLuJe commented Feb 2, 2023

Frenzie commented Feb 2, 2023

poire-z commented Feb 2, 2023

Frenzie commented Feb 2, 2023

NiLuJe commented Feb 2, 2023

Frenzie commented Feb 2, 2023

NiLuJe commented Feb 2, 2023

melyux commented Feb 2, 2023 • edited Loading

Frenzie commented Feb 3, 2023

melyux commented Feb 4, 2023

Frenzie Feb 13, 2023

Choose a reason for hiding this comment

melyux Feb 13, 2023 • edited Loading

Choose a reason for hiding this comment

Frenzie Feb 13, 2023

Choose a reason for hiding this comment

melyux Feb 13, 2023 • edited Loading

Choose a reason for hiding this comment

Frenzie Feb 13, 2023

Choose a reason for hiding this comment

melyux Feb 14, 2023

Choose a reason for hiding this comment

poire-z commented Feb 17, 2023

melyux commented Feb 17, 2023

NiLuJe commented Feb 17, 2023

melyux commented Dec 16, 2022 •

edited by Frenzie

Loading

NiLuJe commented Dec 16, 2022 •

edited

Loading

melyux commented Dec 30, 2022 •

edited

Loading

melyux commented Dec 30, 2022 •

edited

Loading

melyux commented Feb 2, 2023 •

edited

Loading

melyux Feb 13, 2023 •

edited

Loading

melyux Feb 13, 2023 •

edited

Loading