Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appimage: install missing libsndio7.0 package #90

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Apr 10, 2024

The sndio library is required for creating the appimage.


This change is Reviewable

The sndio library is required for creating the appimage.
@benoit-pierre
Copy link
Contributor Author

With koreader/koreader#11662 I can run ./kodev release appimage successfully.

Except I have to force the DOCKER variable to 1 in the Makefile, as the detection is not working. I just switched to rootless mode, so that might be the issue.

@Frenzie Frenzie merged commit dbf52c4 into koreader:master Apr 11, 2024
@Frenzie
Copy link
Member

Frenzie commented Apr 11, 2024

A quick search suggests you can detect Docker by the existence of /.dockerenv. I can confirm that works for me.

https://superuser.com/questions/1021834/what-are-dockerenv-and-dockerinit/1115029#1115029

But since it might change depending on the Docker version (and presumably Podman won't have a /.dockerenv) , I think we should simply add our own "yup, this is Docker" file to the image.

For detection perhaps we should still say if our_this_is_docker_file or /.dockerenv as a generic fallback in case someone uses their own maximalist development Docker image?

@benoit-pierre benoit-pierre deleted the pr/fix_appimage branch April 11, 2024 15:10
@benoit-pierre
Copy link
Contributor Author

Or we could switch to a more simpler approach:

# Is fuse support available?
USE_FUSE ?= $(wildcard /dev/fuse)

Which works in Docker / Podman, and also provides an escape hatch (make USE_FUSE=, useful for testing).

@Frenzie
Copy link
Member

Frenzie commented Apr 11, 2024

Implemented in koreader/koreader#11669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants