Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation issue v0.0.8 #12

Closed
avocadotruck94 opened this issue Mar 25, 2021 · 2 comments · Fixed by #14
Closed

Installation issue v0.0.8 #12

avocadotruck94 opened this issue Mar 25, 2021 · 2 comments · Fixed by #14

Comments

@avocadotruck94
Copy link

Hi,

I'm running into an installation issue with v0.0.8 on the following vscode setup

Version: 1.54.3
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.8.0-48-generic snap
Ubuntu 20.04 LTS 64-bit

The extension doesn't get loaded after installation, even after window reload and vscode restart. The issue manifests through the lack of color/syntax highlighting and no salt related auto completion suggestions when pressing ctrl+space (just the default vscode text suggestions). I first thought this might be due to conflict with Better Jinja and salt-lint extensions but still had the same issue after uninstalling them.

The workaround for now has been

  1. Install extension
  2. Install a lower version which enables the "Reload required" button
  3. Press the "Reload required" button
  4. Update to the latest version
  5. Press the "Reload required" button again

This seems to load the extension properly. Perhaps there is a way to reload the extension directly through the command palette?

Either way, minor issue but thought I'd mention it.

Best regards
@hatifnatt
Copy link

Faced with same issue

Version: 1.54.3
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.11.14-1-MANJARO

After installation of version 0.0.8 only SaltStack (tst) language available for selection. Workaround described above helped SaltStack (sls) language appeared in selection dialogue, after downgrade to version 0.0.6. But after upgrade to 0.0.8 it's gone and only SaltStack (tst) available.

@roaldnefs roaldnefs mentioned this issue Jun 4, 2021
Closed
roaldnefs added a commit to roaldnefs/vscode-saltstack that referenced this issue Jun 4, 2021
@roaldnefs
fix: vscode language id for sls files
c49d0d0 
Fix VSCode language ID for .sls files by combining the `.tst` and `.sls`
extensions into a single VSCode language entry.

Fixes: korekontrol#12
Fixes: warpnet/vscode-salt-lint#10

Signed-off-by: Roald Nefs <info@roaldnefs.com>
@roaldnefs roaldnefs mentioned this issue Jun 4, 2021
Merged
@marek-obuchowicz
Copy link
Contributor

Release 0.0.9 has arrived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix VSCode language ID for sls files roaldnefs/vscode-saltstack
3 participants
@marek-obuchowicz @hatifnatt @avocadotruck94