Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: update for new version #7

Closed
wants to merge 1 commit into from

Conversation

jrfnl
Copy link

@jrfnl jrfnl commented Oct 14, 2022

Looks like this action runner is not using "long-running branches", which means that to use the latest version of this action runner, the usage instructions need to be updated.

Alternatively, please consider having a v1 tag which moves on every release within the 1.x range or have a v1 branch for the whole 1.x development cycle.
This would mean that people would automatically get the latest version and don't have to update their workflows.

Looks like this action runner is not using "long-running branches", which means that to use the latest version of this action runner, the usage instructions need to be updated.

Alternatively, please consider having a `v1` tag which moves on every release within the `1.x` range or have a `v1` branch for the whole `1.x` development cycle.
This would mean that people would automatically get the latest version and don't have to update their workflows.
jrfnl added a commit to Automattic/VIP-Coding-Standards that referenced this pull request Oct 14, 2022
The `xmllint-problem-matcher` action runner has released a new version which updates it to use node 16.
This gets rid of a warning which was shown in the action logs.

Note: I've [suggested to the author to use long-running branches for the action runner instead](korelstar/xmllint-problem-matcher#7), which would make this update redundant, but no telling if or when they'll respond to that, let alone if they will follow my suggestion.

Refs:
* https://github.com/korelstar/xmllint-problem-matcher/releases/tag/v1.1
jrfnl added a commit to Automattic/VIP-Coding-Standards that referenced this pull request Oct 14, 2022
The `xmllint-problem-matcher` action runner has released a new version which updates it to use node 16.
This gets rid of a warning which was shown in the action logs.

Note: I've [suggested to the author to use long-running branches for the action runner instead](korelstar/xmllint-problem-matcher#7), which would make this update redundant, but no telling if or when they'll respond to that, let alone if they will follow my suggestion.

Refs:
* https://github.com/korelstar/xmllint-problem-matcher/releases/tag/v1.1
jrfnl added a commit to jrfnl/PHP_CodeSniffer that referenced this pull request Oct 14, 2022
The `xmllint-problem-matcher` action runner has released a new version which updates it to use node 16.
This gets rid of a warning which was shown in the action logs.

Note: I've [suggested to the author to use long-running branches for the action runner instead](korelstar/xmllint-problem-matcher#7), which would make this update redundant, but no telling if or when they'll respond to that, let alone if they will follow my suggestion.

Refs:
* https://github.com/korelstar/xmllint-problem-matcher/releases/tag/v1.1
jrfnl added a commit to PHPCompatibility/PHPCompatibility that referenced this pull request Oct 14, 2022
The `xmllint-problem-matcher` action runner has released a new version which updates it to use node 16.
This gets rid of a warning which was shown in the action logs.

Note: I've [suggested to the author to use long-running branches for the action runner instead](korelstar/xmllint-problem-matcher#7), which would make this update redundant, but no telling if or when they'll respond to that, let alone if they will follow my suggestion.

Refs:
* https://github.com/korelstar/xmllint-problem-matcher/releases/tag/v1.1
jrfnl added a commit to sirbrillig/phpcs-variable-analysis that referenced this pull request Oct 14, 2022
The `xmllint-problem-matcher` action runner has released a new version which updates it to use node 16.
This gets rid of a warning which was shown in the action logs.

Note: I've [suggested to the author to use long-running branches for the action runner instead](korelstar/xmllint-problem-matcher#7), which would make this update redundant, but no telling if or when they'll respond to that, let alone if they will follow my suggestion.

Refs:
* https://github.com/korelstar/xmllint-problem-matcher/releases/tag/v1.1
jrfnl added a commit to WordPress/WordPress-Coding-Standards that referenced this pull request Oct 14, 2022
The `xmllint-problem-matcher` action runner has released a new version which updates it to use node 16.
This gets rid of a warning which was shown in the action logs.

Note: I've [suggested to the author to use long-running branches for the action runner instead](korelstar/xmllint-problem-matcher#7), which would make this update redundant, but no telling if or when they'll respond to that, let alone if they will follow my suggestion.

Refs:
* https://github.com/korelstar/xmllint-problem-matcher/releases/tag/v1.1
@korelstar
Copy link
Owner

Hey @jrfnl , thanks for your remarks! To be honest: I did some mistakes when publishing the last release (v1.1). I've tried to correct these:

  • latest release is now tagged with v1.1.0
  • the tag v1 points to v1.1.0, so that nobody has to do anything when using korelstar/xmllint-problem-matcher@v1
  • the tag v1.1 also points to v1.1.0, so that people that already moved to korelstar/xmllint-problem-matcher@v1.1 do not need to change anything
  • I renamed the old v1 release to v1.0.0

Sorry for these confusions, this was not best practice.

From now on, I will create releases using the semantic versioning structure (vMAJOR.MINOR.PATCH) and I will move the major version tag (e.g. v1) to the latest release of that major version.

Could you please check if everything is fine, now?

@jrfnl
Copy link
Author

jrfnl commented Oct 27, 2022

@korelstar Sorry for my delayed response!

I have tested with a couple of repos and can confirm all is fine now. For those repos in which I'd already switched to v1.1, I've reverted back to v1 to be able to benefit from future 1.x releases automatically.

I will close this PR now as it is no longer needed.

Thank you for your prompt action and for maintaining this project!

@jrfnl jrfnl closed this Oct 27, 2022
@jrfnl jrfnl deleted the feature/readme-update branch October 27, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants