Add Norwegian locale and corresponding test (failing as pr issue #146) #147

Dambakk · 2020-10-19T17:07:40Z

See issue #146

…ibs-archive#146)

…tests. See issue korlibs-archive#146.

Dambakk · 2020-10-19T19:09:09Z

This PR has expanded according to the findings described in #146

soywiz · 2020-10-20T12:18:54Z

First of all, thanks for the contribution @Dambakk !

I think we should have in mind several things:

This is changing the current behaviour. This is something we can consider for 2.0 as a breaking change, or opt-in/out with a setting or something.

We should ask people from different countries to validate the dates format and maybe also check against other libraries.
In Spanish for example I believe it is not capitalized between words, so could make sense. But in English I'm not fully sure since Title Case is usually common: https://dictionary.cambridge.org/grammar/british-grammar/dates
AFAIK in Japanese and Chinese no capitalization is required, but need to validate.

Going to ask on slack/discord, also if people subscribed to this repo can check, let's see if people from other countries have feedback on this for their respective languages, so lets wait a few days for this to happen if you don't mind 👍

RezMike · 2020-10-20T12:37:17Z

klock/src/commonTest/kotlin/com/soywiz/klock/locale/KlockLocaleTest.kt

@@ -119,12 +137,12 @@ class KlockLocaleTest {
 	fun testRussianLocale() {
 		assertEquals(
 			"""
-			Ср, 13 Мар 2019 21:36:45 UTC
-			13 Мар 2019 г. 21:36:45
+			ср, 13 мар 2019 21:36:45 UTC


The day of the week ("ср") should start with an upper letter ("Ср")

Hi! Can you confirm that all weekdays in two-letter short form should start with an upper case letter?

override val daysOfWeekShort = listOf( "вс", "пн", "вт", "ср", "чт", "пт", "сб" )

Can you type them here so it gets correct?

Like that?

override val daysOfWeekShort = listOf( "Вс", "Пн", "Вт", "Ср", "Чт", "Пт", "Сб" )

klock/src/commonTest/kotlin/com/soywiz/klock/locale/KlockLocaleTest.kt

Dambakk · 2020-10-20T13:00:50Z

Of course this can wait, @soywiz!

I totally agree that this should be targeted for a major version. At least we are aware of the situation. I'm not a language person myself, but I hope the community will contribute with their knowledge. I can take responsibility to update this PR as we receive feedback.

Can you point me to any documentation that needs to be updated?

tisoft · 2020-10-20T13:21:52Z

German is looking good.

joost-klitsie · 2020-10-20T15:44:01Z

Dutch is looking good, officially the months/weekdays should not be capiticalized: https://onzetaal.nl/taaladvies/oktober-october/

andriipanasiuk · 2020-10-21T11:23:08Z

klock/src/commonTest/kotlin/com/soywiz/klock/locale/KlockLocaleTest.kt

@@ -173,12 +191,12 @@ class KlockLocaleTest {
 	fun testUkrainianLocale() {
 		assertEquals(
 			"""
-			Ср, 13 Бер 2019 21:36:45 UTC
-			13 Бер 2019 р. 21:36:45
+			ср, 13 бер 2019 21:36:45 UTC


For Ukrainian, the day of the week should start with an upper letter: "Ср" instead of "ср".

Hi!
Can you confirm that this is the correct two-letter short form for weekdays in Ukrainian?

override val daysOfWeekShort = listOf( "нд", "пн", "вт", "Ср", "чт", "пт", "сб" )

andriipanasiuk · 2020-10-21T11:24:20Z

klock/src/commonTest/kotlin/com/soywiz/klock/locale/KlockLocaleTest.kt

-			Середа, 13 Березня 2019 р.
-			13 Березня 2019 р.
-			13 Бер 2019 р.
+			середа, 13 березня 2019 р.


The full format of the day of the week should start with an upper letter as well.
"Середа" instead of "середа"

Hi!
Can you confirm that these weekdays are correct?

override val daysOfWeek = listOf( "неділя", "понеділок", "вівторок", "Середа", "четвер", "п'ятниця", "субота" )

I'm cross-checking with how Java DateTime does formatting and gets an exception:

Expected :середа, 18 січня 1995 21:36:45 // <- Java Actual :Середа, 18 січня 1995 21:36:45 // <- Klock

Can you confirm that Java is wrong and that it should be uppercased?

andriipanasiuk · 2020-10-21T11:30:57Z

Left few comments for Ukrainian locale. Weekdays should be capitalized.

soywiz · 2020-10-22T04:18:11Z

Thank you all for the help!

Can you point me to any documentation that needs to be updated?

Klock documentation is on this file:

https://github.com/korlibs/korlibs.soywiz.com/blob/1ec80907cc805ced88a1bd495e8acf1d4473350c/klock/index.md

Also I have been thinking. Would be nice to be consisent with what Java and other libraries do in the case the behaviour is the same or very similar. What would you think on adding a test checking different locales on the jvmTest sourceSet that uses both klock and the JVM API to generate dates with weekdays and months and compare the results? That way we are completely confident to be consistent at least with the JVM.

moment().format("dddd, MMMM Do YYYY, h:mm:ss a"); // "Sunday, February 14th 2010, 3:25:50 pm"

I have also checked what does moment.js (not checked JVM), and seems to be different per language. Check the results here:

https://jsfiddle.net/soywiz/j35yht7a/6/

for (let lang of ['nb_NO', 'en', 'de', 'es', 'fr', 'zh-cn', 'ja-jp', 'pt_PT', 'nl-NL', 'ru']) {
	document.write('<p>' + lang + ": " + moment().locale(lang).format('dddd, MMMM Do YYYY, h:mm:ss a') + '</p>')
}

nb_NO: torsdag, oktober 22. 2020, 6:16:35 am
en: Thursday, October 22nd 2020, 6:16:35 am
de: Donnerstag, Oktober 22. 2020, 6:16:35 am
es: jueves, octubre 22º 2020, 6:16:35 am
fr: jeudi, octobre 22 2020, 6:16:35 am
zh-cn: 星期四, 十月 22日 2020, 6:16:35 早上
ja-jp: 木曜日, 10月 22日 2020, 6:16:35 午前
pt_PT: Quinta-feira, outubro 22º 2020, 6:16:35 am
nl-NL: donderdag, oktober 22ste 2020, 6:16:35 am
ru: четверг, октябрь 22-го 2020, 6:23:57 утра

We could also check this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat

That is the standard i18n for Ecmascript

Dambakk · 2020-10-22T16:50:35Z

That sounds like a great idea! I will look into it 👍

Dambakk · 2020-10-22T18:26:12Z

Strange, Portuguese is running fine on my computer. Both produce lowercased output.

soywiz · 2020-10-23T15:20:15Z

@Dambakk Nice. It's a pity that it didn't work consistently.
Korlibs libraries are compiled using JDK8 as far as I remember, to prevent bytecode issues, so maybe you are using a greater JVM version where the behaviour changed?
Can you try different versions of the JVM with your branch and see what happens?

If the behaviour is changed, maybe we should stick to specific literals, based on what's more common comparing with other libraries/frameworks like moment.js, the standardized version of ecmascript, several versions of the JVM, .NET, Swift.

If you need help with that I can make samples in different languages and put here the code + output when I have some time.

Dambakk · 2020-10-24T19:50:24Z

I was running java 12 so that might be it. IDEA crashed when I changed it to jdk 8 :P but since both the tests here and moment.js says something different than my computer I guess they are right ;)

However, Russian is failing now.. moment.js and my computer say weekdays should start with lowercase letter, whilst java 8(?) say weekdays should start with uppercased.. What do you think?

Anything else that you think should be done here? I can update the documentation once the PR is approved.

soywiz · 2020-10-25T13:23:45Z

Uhm. Tests are still failing. Maybe we should use string literals instead

soywiz · 2020-10-25T13:47:42Z

.NET:

using System;
using System.Globalization;

namespace ConsoleApp1
{
    class Program
    {
        static void Main(string[] args)
        {
            var date = new DateTime(2020, 10, 25, 14, 10, 13);
            var format = "dddd, dd MMMM yyyy hh:mm:ss tt";
            foreach (var lang in new[] {"nb_NO", "en", "de", "es", "fr", "zh-cn", "ja-jp", "pt_PT", "nl-NL", "ru"})
            {
                var str = date.ToString(format, CultureInfo.GetCultureInfo(lang));
                Console.WriteLine($"{lang}: {str}");
            }
        }
    }
}

nb_NO: søndag, 25 oktober 2020 02:10:13 p.m.
en: Sunday, 25 October 2020 02:10:13 PM
de: Sonntag, 25 Oktober 2020 02:10:13 PM
es: domingo, 25 octubre 2020 02:10:13 p. m.
fr: dimanche, 25 octobre 2020 02:10:13 PM
zh-cn: 星期日, 25 十月 2020 02:10:13 下午
ja-jp: 日曜日, 25 10月 2020 02:10:13 午後
pt_PT: domingo, 25 outubro 2020 02:10:13 PM
nl-NL: zondag, 25 oktober 2020 02:10:13 p.m.
ru: воскресенье, 25 октября 2020 02:10:13 PM

soywiz · 2020-10-25T13:49:40Z

In .NET looks similar to moment.js (english and german the only ones capitalized), except for Portuguese that is non-capitalized on .NET

soywiz · 2020-10-25T13:55:52Z

On standard modern JavaScript using Intl:

let date = new Date(Date.UTC(2020, 9, 25, 14, 10, 13));
let options = {weekday: 'long', year: 'numeric', month: 'long', day: 'numeric', timeZone: 'UTC', timeZoneName: 'short'};

for (let lang of ['nb-NO', 'en', 'de', 'es', 'fr', 'zh-cn', 'ja-jp', 'pt-PT', 'nl-NL', 'ru']) {
    try {
        let str = new Intl.DateTimeFormat(lang, options).format(date);
        console.log(`${lang}: ${str}`);
    } catch (e) {
        console.error(`Invalid locale ${lang}`);
    }
}

nb-NO: søndag 25. oktober 2020, UTC
en: Sunday, October 25, 2020, UTC
de: Sonntag, 25. Oktober 2020, UTC
es: domingo, 25 de octubre de 2020 UTC
fr: dimanche 25 octobre 2020 à UTC
zh-cn: 2020年10月25日星期日 UTC
ja-jp: 2020年10月25日日曜日 UTC
pt-PT: domingo, 25 de outubro de 2020, UTC
nl-NL: zondag 25 oktober 2020 UTC
ru: воскресенье, 25 октября 2020 г., UTC

Seems to work the same as on .NET, only English and German are capitalized

soywiz · 2020-10-25T14:06:36Z

Swift:

import Foundation

let date = Date.init()
let dateFormatter = DateFormatter()
dateFormatter.dateStyle = .long
dateFormatter.timeStyle = .long
for lang in ["nb-NO", "en", "de", "es", "fr", "zh-cn", "ja-jp", "pt-PT", "nl-NL", "ru"] {
    dateFormatter.locale = Locale.init(identifier: lang)
    print(dateFormatter.string(from: date))
}

25. oktober 2020 kl. 15:04:47 CET
October 25, 2020 at 3:04:47 PM GMT+1
25. Oktober 2020 um 15:04:47 MEZ
25 de octubre de 2020, 15:04:47 CET
25 octobre 2020 à 15:04:47 UTC+1
2020年10月25日 GMT+1 下午3:04:47
2020年10月25日 15:04:47 GMT+1
25 de outubro de 2020, 15:04:47 CET
25 oktober 2020 om 15:04:47 CET
25 октября 2020 г. в 15:04:47 GMT+1

Again, in terms of capitalization, only english and german. So I would go that way

Dambakk · 2020-10-27T17:46:22Z

Finally, the tests run successfully! Please go ahead with code review, @soywiz .

klock/src/jvmTest/kotlin/com/soywiz/klock/KlockLocaleTestJvm.kt

soywiz · 2020-10-27T20:26:16Z

LGTM Thanks!

soywiz · 2020-10-27T20:26:43Z

Fixes #146

Dambakk added 2 commits October 19, 2020 19:06

Add Norwegian locale and corresponding test (failing as pr issue korl…

499c088

…ibs-archive#146)

Change format method to use localized names for days and months. Fix …

2d6f979

…tests. See issue korlibs-archive#146.

soywiz added this to KorGE 2.0 in Korlibs Oct 20, 2020

RezMike suggested changes Oct 20, 2020

View reviewed changes

andriipanasiuk reviewed Oct 21, 2020

View reviewed changes

Dambakk added 2 commits October 22, 2020 19:03

Update russian and ukrainian weekdays based on PR feedback

addb287

Create jvm tests to cross check localization to java DateTime formatting

baf202d

Dambakk requested a review from RezMike October 22, 2020 18:19

Fix failing portuguese test and feedback on russian weekday translation

3bac878

Dambakk added 2 commits October 27, 2020 18:22

Final fixes to localization tests

d4f2284

Fix failing portuguese test

b836be6

soywiz reviewed Oct 27, 2020

View reviewed changes

klock/src/jvmTest/kotlin/com/soywiz/klock/KlockLocaleTestJvm.kt Outdated Show resolved Hide resolved

Refactor after code review

6cd26f3

Dambakk requested a review from soywiz October 27, 2020 20:18

soywiz merged commit 7ecf095 into korlibs-archive:master Oct 27, 2020

Korlibs automation moved this from KorGE 2.0 to Done Oct 27, 2020

Dambakk deleted the feature/norwegian-locale branch October 27, 2020 20:27

soywiz removed this from Done in Korlibs Jul 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Norwegian locale and corresponding test (failing as pr issue #146) #147

Add Norwegian locale and corresponding test (failing as pr issue #146) #147

Dambakk commented Oct 19, 2020 •

edited

Dambakk commented Oct 19, 2020

soywiz commented Oct 20, 2020

RezMike Oct 20, 2020

Dambakk Oct 22, 2020

RezMike Oct 22, 2020

Dambakk commented Oct 20, 2020

tisoft commented Oct 20, 2020

joost-klitsie commented Oct 20, 2020

andriipanasiuk Oct 21, 2020

Dambakk Oct 22, 2020

andriipanasiuk Oct 21, 2020

Dambakk Oct 22, 2020

Dambakk Oct 22, 2020

andriipanasiuk commented Oct 21, 2020

soywiz commented Oct 22, 2020 •

edited

Dambakk commented Oct 22, 2020

Dambakk commented Oct 22, 2020

soywiz commented Oct 23, 2020

Dambakk commented Oct 24, 2020

soywiz commented Oct 25, 2020

soywiz commented Oct 25, 2020

soywiz commented Oct 25, 2020

soywiz commented Oct 25, 2020

soywiz commented Oct 25, 2020

Dambakk commented Oct 27, 2020

soywiz commented Oct 27, 2020

soywiz commented Oct 27, 2020

Add Norwegian locale and corresponding test (failing as pr issue #146) #147

Add Norwegian locale and corresponding test (failing as pr issue #146) #147

Conversation

Dambakk commented Oct 19, 2020 • edited

Dambakk commented Oct 19, 2020

soywiz commented Oct 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dambakk commented Oct 20, 2020

tisoft commented Oct 20, 2020

joost-klitsie commented Oct 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andriipanasiuk commented Oct 21, 2020

soywiz commented Oct 22, 2020 • edited

Dambakk commented Oct 22, 2020

Dambakk commented Oct 22, 2020

soywiz commented Oct 23, 2020

Dambakk commented Oct 24, 2020

soywiz commented Oct 25, 2020

soywiz commented Oct 25, 2020

soywiz commented Oct 25, 2020

soywiz commented Oct 25, 2020

soywiz commented Oct 25, 2020

Dambakk commented Oct 27, 2020

soywiz commented Oct 27, 2020

soywiz commented Oct 27, 2020

Dambakk commented Oct 19, 2020 •

edited

soywiz commented Oct 22, 2020 •

edited