This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Fix loading frame cells in Aseprite files #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Then the Aseprite file contains empty cells in a to-be-loaded layer then it did not create ImageFrame objects for those empty cells. That lead to the problem that an animation could not be played. Now empty ImageFrame objects are created for empty cells. This fixes the problem. Unit test added to check if the frame array in the loaded Aseprite image has the correct length.
|
Nice. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then the Aseprite file contains empty cells in a to-be-loaded layer then
it did not create ImageFrame objects for those empty cells. That lead to
the problem that an animation could not be played if there are empty
cells in frames before the animation tag.
Now empty ImageFrame objects are created for empty cells. This fixes the
problem.
Unit test added to check if the frame array in the loaded Aseprite image
has the correct length.