preg_match() unkown modifier '?' in valid.php .

[masthisis]

/**
* Checks whether a string is a valid number (negative and decimal numbers allowed).
*
* Uses {@link http://www.php.net/manual/en/function.localeconv.php locale conversion}
* to allow decimal point to be locale specific.
*
* @param string $str input string
* @return boolean
*/
public static function numeric($str)
{
// Get the decimal point for the current locale
list($decimal) = array_values(localeconv());

	// A lookahead is used to make sure the string contains at least one digit (before or 
                after the decimal point)
	 return (bool) preg_match('/^-?+(?=.*[0-9])[0-9]*+'.preg_quote($decimal).'?+[0-9]*+$/D', (string) $str); }

// my solution : return (bool) true ; :)

** but what is that error for??? **

[masthisis]

@neo22s @Azuka @stik @juherr

[WinterSilence]

@mas1375 php 7.3? add dump localeconv()

rework:

/**
 * Checks whether a value is a valid number (negative and decimal numbers allowed).
 *
 * @param   mixed  $value
 * @return  boolean
 */
public static function numeric($value)
{
    if (is_numeric($value))
    {
        if ((intval($value) === $value) OR (floatval($value) === $value))
        {
            return TRUE;
        }
        // To make sure the value contains at least one digit (before/after the decimal point)
        $locale = localeconv();
        return (bool) preg_match(
            '/^-?+(?=.*\d)\d*+['.preg_quote($locale['decimal_point']).']?+\d*+$/D',
            $value
        );
    }
    return FALSE;
}

[masthisis]

@WinterSilence PHP 7.2.
thanks.

[WinterSilence]

@mas1375 show dump localeconv(), changes in regexp only in php 7.3 - i think problem in incorrect pointer.

[toitzi]

@mas1375 @WinterSilence cannot reproduce this one. Is it a error / issue of the framework?

[masthisis]

it's localeconv() dump :

array (size=18)
  'decimal_point' => string '/' (length=1)
  'thousands_sep' => string ',' (length=1)
  'int_curr_symbol' => string 'IRR' (length=3)
  'currency_symbol' => string 'ريال' (length=8)
  'mon_decimal_point' => string '/' (length=1)
  'mon_thousands_sep' => string ',' (length=1)
  'positive_sign' => string '' (length=0)
  'negative_sign' => string '-' (length=1)
  'int_frac_digits' => int 2
  'frac_digits' => int 2
  'p_cs_precedes' => int 0
  'p_sep_by_space' => int 0
  'n_cs_precedes' => int 0
  'n_sep_by_space' => int 0
  'p_sign_posn' => int 3
  'n_sign_posn' => int 3
  'grouping' => 
    array (size=1)
      0 => int 3
  'mon_grouping' => 
    array (size=1)
      0 => int 3

and the $str value is : '26' (string) $str)

[WinterSilence]

@toitzi as i already say, problem in 'decimal_point' => string '/' (length=1). This class use many strange and legacy solutions :(

[toitzi]

@WinterSilence Thanks for clarification!

[toitzi]

@WinterSilence Does your code above fix it? Can you make a PR out of it?

[WinterSilence]

@toitzi i cant: new github plugin for atom ide use direct pull (i think its bug), i cant use old plugin - ide not support it

[masthisis]

@mas1375 php 7.3? add dump localeconv()

rework:

/**
 * Checks whether a value is a valid number (negative and decimal numbers allowed).
 *
 * @param   mixed  $value
 * @return  boolean
 */
public static function numeric($value)
{
    if (is_numeric($value))
    {
        if ((intval($value) === $value) OR (floatval($value) === $value))
        {
            return TRUE;
        }
        // To make sure the value contains at least one digit (before/after the decimal point)
        $locale = localeconv();
        return (bool) preg_match(
            '/^-?+(?=.*\d)\d*+['.preg_quote($locale['decimal_point']).']?+\d*+$/D',
            $value
        );
    }
    return FALSE;
}

there is another solution for it, according to the manual :

Note that / is not a special regular expression character.
[...]
delimiter
If the optional delimiter is specified, it will also be escaped. This is useful for escaping the delimiter that is required by the PCRE functions. The / is the most commonly used delimiter.

so :

return (bool) preg_match('/^-?+(?=.*[0-9])[09]*+' . preg_quote($decimal, '/') . '?+[0-9]*+$/D', (string) $str);