Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #361

Merged
merged 1 commit into from May 9, 2019
Merged

Bug fixes #361

merged 1 commit into from May 9, 2019

Conversation

masthisis
Copy link

@masthisis masthisis commented Apr 30, 2019

fixing the bug related to this error preg_match() unknown modifier

PR Details

when decimal_point is '/' and it's not a special regular expression character. according to the manual:

delimiter
If the optional delimiter is specified, it will also be escaped. This is useful for escaping the delimiter that is required by the PCRE functions. The ' / ' is the most commonly used delimiter.

Related Issue

Issue #351

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

 - fixed an issue with preg_quote() .
 - Closes koseven#351
@koseven koseven deleted a comment from coveralls May 9, 2019
@toitzi
Copy link
Member

toitzi commented May 9, 2019

Great, thanks a lot! :)

@toitzi toitzi merged commit e4cf777 into koseven:devel May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants