Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webp support #329

Merged
merged 3 commits into from
Mar 13, 2019
Merged

Webp support #329

merged 3 commits into from
Mar 13, 2019

Conversation

toitzi
Copy link
Member

@toitzi toitzi commented Mar 7, 2019 •
edited
Loading

PR Details

Builtin Support for WEBP images is available since PHP7.1+ therefore we can use it and remove the custom one. Note: also adding unittest files to .gitignore

Related Issue

#326

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@toitzi toitzi self-assigned this Mar 7, 2019
@toitzi toitzi added enhancement Verified Enhancement bug Verified Bug labels Mar 7, 2019
@toitzi toitzi added this to the 4.0.0 milestone Mar 7, 2019
@toitzi toitzi requested review from svenbw and neo22s March 7, 2019 11:34
@koseven koseven deleted a comment from coveralls Mar 7, 2019
@toitzi
Copy link
Member Author

toitzi commented Mar 9, 2019

Can this be merged?

@svenbw svenbw merged commit 4d1124c into koseven:devel Mar 13, 2019
@toitzi toitzi deleted the webp-support branch September 13, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenbw svenbw Awaiting requested review from svenbw

@neo22s neo22s Awaiting requested review from neo22s

Assignees

@toitzi toitzi

Labels
bug Verified Bug enhancement Verified Enhancement
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@toitzi @svenbw