Replace string-based flags with enums #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
This changes all functions that previously accepted a
&str
flag to instead accept an appropriate enum. There are various changes to note:BlurMode
just has touse raster::BlurMode;
."x"
and"y"
, but I changed them toHorizontal
andVertical
, as it's more explicit, expressive, and clear - and thus more rustic. For people with autocompletion, the loss of brevity is a non-issue, though I'd understand if you're not receptive to this change.ResizeMode
. Still, I feel this change may be slightly controversial, which is why I feel the need to mention it here.BlendFunction
enum that's just like the publicBlendMode
enum, except it doesn't have aNormal
variant.BlendFunction
was made specifically for consumption bych_alpha_f
, whereasBlendMode
is part of the public API and used in all other places.