Skip to content

Commit

Permalink
Merge pull request #349 from hiddewie/node-18-20
Browse files Browse the repository at this point in the history
Add Node 18 and 20 to CI, remove 10, 12 and 14
  • Loading branch information
yohanboniface committed Oct 23, 2023
2 parents 478248c + c91d869 commit b9ff1df
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 7 deletions.
15 changes: 12 additions & 3 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,29 @@ on:
pull_request:
branches: [ master ]

concurrency:
group: ${{ github.ref }}
cancel-in-progress: ${{ github.ref_name == 'master' }}

jobs:
build:

runs-on: ubuntu-latest
timeout-minutes: 10

strategy:
matrix:
node-version: [10.x, 12.x, 14.x, 16.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- run: npm install

- run: npm run lint

- run: npm test
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"author": "Yohan Boniface",
"license": "WTFPL",
"engines": {
"npm": ">=1.5.0",
"node": ">=6.9.0"
"npm": ">=8.0.0",
"node": ">=16.0.0"
},
"dependencies": {
"carto": "^1.2.0",
Expand Down
4 changes: 2 additions & 2 deletions test/tile.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ describe('#Tile()', function () {
describe('#render()', function () {

it('should render a PNG of the world', function (done) {
if (process.version.startsWith('v10')) {
// PNG output is not exactly the same in node v10
if (process.version.startsWith('v20')) {
// PNG output is not exactly the same in node v20
this.skip();
}
var tile = new Tile(0, 0, 0);
Expand Down

0 comments on commit b9ff1df

Please sign in to comment.