Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[Bug]] \ Char Doesn't Have Any Effect #46

Closed
WammKD opened this issue Aug 30, 2018 · 5 comments
Closed

[[Bug]] \ Char Doesn't Have Any Effect #46

WammKD opened this issue Aug 30, 2018 · 5 comments

Comments

@WammKD
Copy link

WammKD commented Aug 30, 2018

I've noticed this for a while but I recently downloaded the most recent update (20180827.1408) and I've still noticed it.

Putting a \ after a query pretty much does nothing with the entire buffer being highlighted on C-c C-c and, naturally, a response of "Error: Incorrect syntax near ''."

The version of Emacs I'm currently running is

GNU Emacs 26.1 (build 1, x86_64-apple-darwin17.5.0, Carbon Version 158 AppKit 1561.4) of 2018-06-06

@kostafey
Copy link
Owner

It's a documentation mistake. Please, use / instead of \.

@WammKD
Copy link
Author

WammKD commented Aug 31, 2018

'Fraid that has the same result. I'd originally done that (I thought I'd remember the doc. originally saying to use /, plus there's font-lock highlighting for it when used) but pretty much the exact same thing happens.

@kostafey
Copy link
Owner

Ok. Let's figure out, you have some SQL buffer with a text like this:

select * from sometable
/
select * from othertable

right?
If you use Oracle database, please add :separator "/" to your ejc-create-connection config.

Furthermore, you can place you cursor (point) somewhere in one of this SQL statements and try:
M-x eval-expression [RET] (ejc-get-sql-boundaries-at-point) [RET]
What is the result of such evaluation?

@WammKD
Copy link
Author

WammKD commented Aug 31, 2018

I think I see what the issue is, now. I'd been doing

select * from sometable /
select * from othertable

Doing it as you have it works. I could've sworn I'd done it like above before (hence why I was confused when it wasn't working) but 'could just be my poor memory.

Thanks for helping me figure it out!

Might be worth putting a note in the doc. in case someone else tries what I did?

@kostafey
Copy link
Owner

kostafey commented Sep 1, 2018

Great! I've added some more usage examples. Looks like, I need to make a screencast with all ejs-sql functionality observation, sonce some of it may be not so obvious.

@kostafey kostafey closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants