Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Add empty headers to HTML tables without headers when converted to markdown #1

Merged
merged 1 commit into from
Aug 17, 2019

Conversation

NikolasKomonen
Copy link

@NikolasKomonen NikolasKomonen commented Aug 15, 2019

This is necessary because Markdown will not render a table without a header defined.

Related issue here: giflw#9

Here is an example of the markdown not rendering without the empty table header.

markdownTable

@NikolasKomonen NikolasKomonen changed the title Add blanks headers for HTML tables without headers when converted to markdown Add empty headers to HTML tables without headers when converted to markdown Aug 15, 2019
@kotcrab
Copy link
Owner

kotcrab commented Aug 15, 2019

Looks okay. Can you format the source code so it matches original files?
Also you can undo the changes on MultiMarkdownTest.java, only the formatting was changed. Generally we want to avoid changes like this because it adds unnecessary noise to git history.

@NikolasKomonen NikolasKomonen force-pushed the markdownTableBlankHeader branch 2 times, most recently from 9fcfccf to e9bc6ca Compare August 15, 2019 21:14
@NikolasKomonen
Copy link
Author

@kotcrab Sorry I forgot to revert the MultiMarkdownTest changes. Everything should be fixed up. Let me know if there's anything else that needs a change.

@kotcrab
Copy link
Owner

kotcrab commented Aug 15, 2019

Alright, I see what's wrong. The indentation on your changes is off. This project is unfortunate enough to be using tabs and your changes are using spaces. It may look fine on your end but on Github it's clearly different, you can see it after going to "Files changed" tab.

…markdown

This is necessary because Markdown will not render a table without a header defined

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@NikolasKomonen
Copy link
Author

@kotcrab Yup, found the indentation issues. Everything should be good now.

@kotcrab kotcrab merged commit c8397a1 into kotcrab:master Aug 17, 2019
@kotcrab
Copy link
Owner

kotcrab commented Aug 17, 2019

Looks good now, thanks! I'm going to upload v1.1.0 soon.

@NikolasKomonen NikolasKomonen deleted the markdownTableBlankHeader branch August 20, 2019 03:55
@NikolasKomonen
Copy link
Author

@kotcrab Great to see the change up on the maven repo. Thanks a lot for the help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants