Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Manager extension #624

Closed
LeoColman opened this issue Jan 29, 2019 · 1 comment
Closed

Security Manager extension #624

LeoColman opened this issue Jan 29, 2019 · 1 comment
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Milestone
3.3

Comments

@LeoColman
Copy link
Member

In the line of #524 and #623, we should have a Security Manager extension.

The library System Rules does it with a JUnit rule, specifically in this class.

We can do something similar, and in the same pattern of System Properties (#524) and System Environment Variables (#623), with an extension and helper methods.
@LeoColman LeoColman added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Jan 29, 2019
@sksamuel sksamuel added this to the 3.3 milestone Jan 29, 2019
@LeoColman LeoColman mentioned this issue Jan 29, 2019
Closed
@sksamuel
Copy link
Member

One thing I'd like to think about is project level vs spec level extensions.

Maybe you want to override security manager for a single spec. Or maybe for the entire test suite. Currently we don't offer that.

@sksamuel sksamuel mentioned this issue Jan 30, 2019
Closed
20 tasks
LeoColman added a commit that referenced this issue Feb 8, 2019
@LeoColman
Implement System Security Manager Extensions
266eab0 
This commit implements the System Security Manager Extensions.

A special attention is needed to the System Security Manager, as it's only one for the JVM, it's susceptible to race conditions. This was specified in the documentation.

Implements #624
@LeoColman LeoColman mentioned this issue Feb 8, 2019
Merged
LeoColman added a commit that referenced this issue Feb 13, 2019
@LeoColman
Implement System Security Manager Extensions
c36fe5b 
This commit implements the System Security Manager Extensions.

A special attention is needed to the System Security Manager, as it's only one for the JVM, it's susceptible to race conditions. This was specified in the documentation.

Implements #624
sksamuel pushed a commit that referenced this issue Feb 13, 2019
@LeoColman @sksamuel
Implement System Security Manager Extensions (#640)
4231544 
This commit implements the System Security Manager Extensions.

A special attention is needed to the System Security Manager, as it's only one for the JVM, it's susceptible to race conditions. This was specified in the documentation.

Implements #624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
2 participants
@sksamuel @LeoColman