Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KotlinTest Roadmap 3.3 #628

Closed
19 of 20 tasks
sksamuel opened this issue Jan 30, 2019 · 18 comments
Closed
19 of 20 tasks

KotlinTest Roadmap 3.3 #628

sksamuel opened this issue Jan 30, 2019 · 18 comments
Assignees
Milestone

Comments

@sksamuel
Copy link
Member

sksamuel commented Jan 30, 2019

Features and fixes for 3.3

@sksamuel sksamuel added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Jan 30, 2019
@sksamuel sksamuel added this to the 3.3 milestone Jan 30, 2019
@sksamuel sksamuel changed the title KotlinTest 3.3 KotlinTest Roadmap 3.3 Jan 30, 2019
@sksamuel
Copy link
Member Author

sksamuel commented Feb 5, 2019

I've like to release 3.3 as soon as possible because it's needed for the intellij plugin, which is by far the biggest feature. We can drop whatever we want to get it released.

@LeoColman
Copy link
Member

Ok, keep System Properties, Environment Extensions, perhaps Security Manager Extension as it's code is mostly done at System Rules library.

I'm ok to keep only some of the new matchers, and drop the uninmplemented ones and improvements to a future release.

I don't see why we need to keep Koin support, File management extension, Allow see and issue and Project config for assert softly.

Not sure about retry helpers tho

@LeoColman
Copy link
Member

System properties are done, Environment is very close done and Security Manager will probably follow these 2 examples

@sksamuel
Copy link
Member Author

sksamuel commented Feb 5, 2019

Ok I've bumped out those things.
If you can handle the two matcher tasks, and anything else you want, I will get the intellij plugin ready.

@LeoColman
Copy link
Member

I think that with both Pull Requests being reviewed and approved, we're pretty much ready for this

@sksamuel
Copy link
Member Author

Ok I believe the plugin is just about good to go, with some bugs to fix.
We can't do #612 you said, so lets have a quick look see what else we want to add in then we can release 3.3.0-RC1.

@LeoColman
Copy link
Member

Can't we just go ahead and release what's on master? We're just missing documentation now

@sksamuel
Copy link
Member Author

sksamuel commented Feb 13, 2019 via email

@sksamuel
Copy link
Member Author

Ok just #512 to be approved and #612 to be implemented or dropped, then I think we're good to release RC1.

@sksamuel
Copy link
Member Author

I could sneak in #644 if you think it's a good feature while waiting on #184 to be tested.

@sksamuel
Copy link
Member Author

#644 is in

@leoxs22
Copy link
Contributor

leoxs22 commented Feb 18, 2019

Hey! I've been trying the new release to see if it's everything OK.

Not sure if this has something to do with this release, but when using the 3.3.0-RC2 version, I get this error:

java.lang.UnsupportedClassVersionError: org/junit/jupiter/api/condition/EnabledIfSystemProperty has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

It doesn't happen when using the 3.2.1

It runs the tests anyway, it just appear as an initialization error, but it counts as a failed test:

image

I've tried doing a mvn clean test, but it doesn't make any difference

Let me know if you need more information

@sksamuel
Copy link
Member Author

Seems to be like the upgrade to JUnit Platform 1.4 has caused this. I guess they've compiled it with Java 11 and your runtime doesn't understand that.

I think we should downgrade to 1.3 like before - I didn't realize JUnit 1.4 was using JDK11.

@Kerooker thoughts?

@sksamuel
Copy link
Member Author

Actually I think it's because I have compiled this with JDK11.
So I just need to re-release but make sure it compiles against JDK8.

@sksamuel
Copy link
Member Author

sksamuel commented Feb 18, 2019

It seems it only affect Java files (which that one is).

sam@sam-hp:~/development/workspace/kotlintest/kotlintest/kotlintest-core/build/classes/java/main/org/junit/jupiter/api/condition$ javap -verbose EnabledIfSystemProperty.class | grep "major"
  major version: 55
sam@sam-hp:~/development/workspace/kotlintest/kotlintest/kotlintest-core/build/classes/kotlin/main/io/kotlintest/internal$ javap -verbose ActiveKt.class | grep "major"
  major version: 50

@leoxs22
Copy link
Contributor

leoxs22 commented Feb 18, 2019

Working perfectly now, thanks @sksamuel !

@sksamuel
Copy link
Member Author

Great

@sksamuel
Copy link
Member Author

sksamuel commented Mar 1, 2019

3.3.0 has been released.

@sksamuel sksamuel closed this as completed Mar 1, 2019
@sksamuel sksamuel added roadmap and removed enhancement ✨ Suggestions for adding new features or improving existing ones. labels Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants