Launching coroutine in test lambda does not attach to the correct scope

[sksamuel]

Seems like its not handled so the test doesn't complete properly.

[LeoColman]

This seem critical. I think the reason is tge same as before failing. I'll look into it. We should release a fix ASAP

…

On Thu., Jun. 13, 2019, 16:45 Stephen Samuel, ***@***.***> wrote: Seems like its not handled so the test doesn't complete properly. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#830>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMBCI7OAFJE7SZFXGMNQZDP2KPVVANCNFSM4HX5V5JQ> .

[sksamuel]

Agreed. I've commented on your other fix, so once that's addressed and this, lets release 3.3.3 On Thu, 13 Jun 2019 at 14:50, Leonardo Colman Lopes < notifications@github.com> wrote:

…

This seem critical. I think the reason is tge same as before failing. I'll look into it. We should release a fix ASAP On Thu., Jun. 13, 2019, 16:45 Stephen Samuel, ***@***.***> wrote: > Seems like its not handled so the test doesn't complete properly. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > < #830 >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAMBCI7OAFJE7SZFXGMNQZDP2KPVVANCNFSM4HX5V5JQ > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#830>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGVA7O6E4BBXLBJLURLP2KQJDANCNFSM4HX5V5JQ> .

[sksamuel]

Ok so this only happens if you're using the intellij kotlintest plugin. If you're using the junit one it's fine.

…

On Thu, 13 Jun 2019 at 14:51, Stephen Samuel (Sam) ***@***.***> wrote: Agreed. I've commented on your other fix, so once that's addressed and this, lets release 3.3.3 On Thu, 13 Jun 2019 at 14:50, Leonardo Colman Lopes < ***@***.***> wrote: > This seem critical. > > I think the reason is tge same as before failing. I'll look into it. > > We should release a fix ASAP > > On Thu., Jun. 13, 2019, 16:45 Stephen Samuel, ***@***.***> > wrote: > > > Seems like its not handled so the test doesn't complete properly. > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > < > #830 > >, > > or mute the thread > > < > https://github.com/notifications/unsubscribe-auth/AAMBCI7OAFJE7SZFXGMNQZDP2KPVVANCNFSM4HX5V5JQ > > > > . > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#830>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAFVSGVA7O6E4BBXLBJLURLP2KQJDANCNFSM4HX5V5JQ> > . >

[sksamuel]

Seems to fail for

test("foo") {
  launch {
    error("boom")
  }
}

The test should pick up failures in the nested coroutine.

[sksamuel]

This is a wider bug in that any launched coroutines don't attach to the scope of the text executor. Fixed now in master.