Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ktor: shouldHaveStatus should support HttpStatusCode #914

Closed
sksamuel opened this issue Jul 22, 2019 · 0 comments · Fixed by #915
Closed

Ktor: shouldHaveStatus should support HttpStatusCode #914

sksamuel opened this issue Jul 22, 2019 · 0 comments · Fixed by #915
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.

Comments

@sksamuel
Copy link
Member

Currently, shouldHaveStatus only accepts an int, like shouldHaveStatus(200) but we should support shouldHaveStatus(HttpStatusCodes.OK) as well.
@sksamuel sksamuel added enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project. labels Jul 22, 2019
LeoColman added a commit that referenced this issue Jul 23, 2019
@LeoColman
Add overload to Ktor shouldHaveStatus matcher
9fb5b13 
Closes #914
@LeoColman LeoColman mentioned this issue Jul 23, 2019
Merged
LeoColman added a commit that referenced this issue Jul 23, 2019
@LeoColman
Add overload to Ktor shouldHaveStatus matcher (#915)
402b9b6 
Closes #914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add overload to Ktor shouldHaveStatus matcher kotest/kotest
1 participant
@sksamuel