Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shouldBeSymbolicLink and shouldHaveParent matchers for files (#817) #871

Merged

Conversation

faogustavo
Copy link
Contributor

References #817


Add:

  • Pair.shouldBePair(x,y)
  • File.isSymbolicLink
  • Path.isSymbolicLink
  • File.shouldHaveParent
  • Path.shouldHaveParent
  • Number.shouldHaveRoot

@sksamuel
Copy link
Member

sksamuel commented Jul 3, 2019

Looks great. Are you doing the other two under this PR or do you want me to merge now ?

@faogustavo
Copy link
Contributor Author

I can do the others too. But if you want to split on another task to separate matchers from Files/Path and Number/Pair, I don't see any problem.

@sksamuel sksamuel merged commit 21eae42 into kotest:master Jul 3, 2019
@sksamuel
Copy link
Member

sksamuel commented Jul 3, 2019

Ok merged

@sksamuel sksamuel mentioned this pull request Jul 13, 2019
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants