Added fix for nil carriers. More detail for json exceptions.

kotikan · Apr 13, 2012 · 5c41769 · 5c41769
1 parent 685fe00
commit 5c41769
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/BugSense-iOS/BugSenseJSONGenerator.m b/BugSense-iOS/BugSenseJSONGenerator.m
@@ -299,6 +299,9 @@ + (NSString *) carrierName {
         id telephonyNetworkInfo = [[[telephonyNetworkInfoClass alloc] init] autorelease];
         id carrier = objc_msgSend(telephonyNetworkInfo, sel_getUid("subscriberCellularProvider"));
         NSString *carrierName = (NSString *)objc_msgSend(carrier, sel_getUid("carrierName"));
+        if (carrierName == nil) {
+            carrierName = kCarrierNotFoundStatus;
+        }
         return carrierName;
     } else {
         return kCarrierNotFoundStatus;
@@ -570,8 +573,9 @@ + (NSData *) JSONDataFromCrashReport:(PLCrashReport *)report userDictionary:(NSD
         NSString *jsonString = 
             [[rootDictionary bs_JSONString] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
         return [jsonString dataUsingEncoding:NSUTF8StringEncoding];
-    } @catch (NSException *exception) {
+    } @catch (NSException *jsonException) {
         NSLog(kJSONErrorMsg);
+        NSLog(@"Name: %@, Reason: %@", [jsonException name], [jsonException reason]);
         return nil;
     }
 }
@@ -692,6 +696,7 @@ + (NSData *) JSONDataFromException:(NSException *)exception userDictionary:(NSDi
         return [jsonString dataUsingEncoding:NSUTF8StringEncoding];
     } @catch (NSException *jsonException) {
         NSLog(kJSONErrorMsg);
+        NSLog(@"Name: %@, Reason: %@", [jsonException name], [jsonException reason]);
         return nil;
     }
 }