core: use target _blank when starting oauth from inside iframe

koush · Feb 25, 2023 · 0bdb402 · 0bdb402
1 parent 1588ea2
commit 0bdb402
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/plugins/core/package-lock.json b/plugins/core/package-lock.json
diff --git a/plugins/core/package.json b/plugins/core/package.json
@@ -1,6 +1,6 @@
 {
    "name": "@scrypted/core",
-   "version": "0.1.91",
+   "version": "0.1.92",
    "description": "Scrypted Core plugin. Provides the UI, websocket, and engine.io APIs.",
    "author": "Scrypted",
    "license": "Apache-2.0",

diff --git a/plugins/core/ui/src/interfaces/OauthClient.vue b/plugins/core/ui/src/interfaces/OauthClient.vue
@@ -2,13 +2,20 @@
   <v-btn text color="primary" @click="onClick">Login</v-btn>
 </template>
 <script>
-import RPCInterface from "./RPCInterface.vue";
 import qs from 'query-string';
+import RPCInterface from "./RPCInterface.vue";
 
 export default {
   mixins: [RPCInterface],
   methods: {
     onChange() { },
+    isIFrame() {
+      try {
+        return window.self !== window.top;
+      } catch (e) {
+        return true;
+      }
+    },
     onClick: function () {
       this.rpc()
         .getOauthUrl()
@@ -40,7 +47,8 @@ export default {
             r: window.location.toString(),
           });
           url.search = qs.stringify(querystring);
-          window.location = url.toString();
+          const target = this.isIFrame() ? '_blank' : undefined;
+          window.open(url.toString(), target);
         });
     }
   }