server, client: send full ClusterObject on new eio endpoint #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koush
reviewed
Nov 9, 2023
| @@ -163,7 +163,18 @@ export class ScryptedRuntime extends PluginHttp<HttpPluginData> { | |||
| res.end(); | |||
| return; | |||
| } | |||
| if (!req.query.port) { | |||
| if (!req.query.clusterObject) { | |||
There was a problem hiding this comment.
couple things I'm just now noticing:
the acl check above is not necessary, non-admin users should be able to access this API.
the cluster object validity check should be done below when the connection is initiated. return some error json and terminate the connection there.
I think this whole handler guard can then be removed with connectRPCObjectHandler in place.
There was a problem hiding this comment.
Ok, sounds good will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes the checksums computed on the python side to be symmetric to node's signatures (both now use base64 encoding).