homekit: fix late 2way setup #1461
Conversation
|
|
||
| if (rtp.header.payloadType !== session.startRequest.audio.pt) | ||
| return; | ||
| let initializing = false; |
There was a problem hiding this comment.
This code seems correct, but it was a bit confusing to read due to the addition of a second state variable. Can you make a change with something like:
let twoWayAudioState = 'stopped' | 'starting' | 'started' = 'stopped';This would replace both initializing and playing. Then use this variable throughout to manage check change/check.
There was a problem hiding this comment.
Related: this would seem to allow restarting of the two way audio if it terminates for some reason. I may consider terminating two way audio automatically if homekit stops sending packets (which it does when the mic is disabled on the ios home app). Many cameras operate with echo cancellation during two way audio, which mutes incoming audio to some degree.
There was a problem hiding this comment.
Done. Much easier to read, I agree. And yes, it does allow restarting of the two way audio!
When my ring doorbell sets up a streaming session, the first message on the audio return channel isn't a request to setup 2way. In that case, the "once" handler would fire (and bail) and when the real 2way setup message would arrive, the setup listener was no longer registered and nothing would happen. This PR moves the 2way setup into the always-on listener, and creates a guard to prevent multiple setup requests from running concurrently. It should also allow retrying the setup if something temporarily went wrong on a previous attempt.