Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in new --runtime web-extension feature #151

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

Pauan
Copy link
Contributor

@Pauan Pauan commented Nov 14, 2018

Since it's specific for web extensions, the runtime is much smaller (it doesn't need Node support, or instantiateStreaming fallbacks, or UMD).

I didn't see any tests for the other runtime options, so I didn't add any.

@koute
Copy link
Owner

koute commented Nov 14, 2018

Thanks for the PR!

It'd be nice to have a test purely to make sure we don't break this functionality by a mistake in the future. (e.g. we could probably add a testcase like the build_and_run_native_wasm in integration-tests which would compile a test crate and run it with Node.js using a simple shim similar in concept to src/test_runner.js which would inject a fake getURL and eval the thing)

But looks good to me otherwise! Thanks!

@koute koute merged commit 4fdf766 into koute:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants