Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #315

Merged
merged 2 commits into from
May 12, 2023
Merged

Update README.md #315

merged 2 commits into from
May 12, 2023

Conversation

joyfulrabbit
Copy link
Contributor

tiny changes, big impact

@joyfulrabbit
Update README.md
75d99a2 
tiny changes, big impact
@joyfulrabbit joyfulrabbit mentioned this pull request May 10, 2023
Closed
mrueg
mrueg reviewed May 12, 2023
View reviewed changes
Copy link
Collaborator

@mrueg mrueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks, one request: Please use the new options with -

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@joyfulrabbit
Copy link
Contributor Author

Ship it!

@mrueg
Copy link
Collaborator

mrueg commented May 12, 2023

@joyfulrabbit can you push it again? Looks like these are still your initial changes.

@joyfulrabbit
Update README.md
de5804e 
updated per mrueg suggestions
@mrueg mrueg merged commit 5602297 into kovetskiy:master May 12, 2023
@mrueg
Copy link
Collaborator

mrueg commented May 12, 2023

Thanks!

@joyfulrabbit joyfulrabbit deleted the example-fix branch May 12, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrueg mrueg mrueg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joyfulrabbit @mrueg