Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#317] Minor documentation improvements (part 3) #356

Merged
merged 3 commits into from
Mar 10, 2021
Merged

[#317] Minor documentation improvements (part 3) #356

merged 3 commits into from
Mar 10, 2021

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Mar 10, 2021

Resolves #317

@vrom911 vrom911 requested a review from chshersh as a code owner March 10, 2021 16:52
@vrom911 vrom911 self-assigned this Mar 10, 2021
@vrom911 vrom911 added the doc README, Haddock documentation, tutorials label Mar 10, 2021
chshersh
chshersh approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Even better documentation now 🤓 📖

src/Relude.hs
@@ -3,7 +3,7 @@
{- |
Copyright: (c) 2016 Stephen Diehl
(c) 2016-2018 Serokell
(c) 2018-2020 Kowainik
(c) 2018-2021 Kowainik
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating all the years! 2️⃣ 0️⃣ 2️⃣ 1️⃣ 🎉 🎅🏻

src/Relude/Applicative.hs
Comment on lines +47 to +52
@
printJust :: Maybe Int -> IO ()
printJust mInt = case mInt of
Just i -> putStrLn $ "Number: " ++ show i
Nothing -> pass
@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example!

src/Relude/Extra/Foldable.hs Outdated Show resolved Hide resolved
src/Relude/Extra/Foldable.hs Outdated Show resolved Hide resolved
vrom911 and others added 2 commits March 10, 2021 17:31
@chshersh chshersh merged commit dba0482 into main Mar 10, 2021
@chshersh chshersh deleted the vrom911/317-Minor-documentation-improvements-part-3 branch March 10, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
doc README, Haddock documentation, tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor documentation improvements (part 3)
2 participants
@vrom911 @chshersh