Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Semigroup' and 'Monoid' instances for 'TOML' type #10

Closed
chshersh opened this issue Mar 29, 2018 · 1 comment
Closed

Add 'Semigroup' and 'Monoid' instances for 'TOML' type #10

chshersh opened this issue Mar 29, 2018 · 1 comment
Assignees
@vrom911
Labels
ast Type of TOML
Milestone
v1.0.0: Public re...

Comments

@chshersh
Copy link
Contributor

No description provided.

@chshersh chshersh added the ast Type of TOML label Mar 29, 2018
@chshersh
Copy link
Contributor Author

chshersh commented Apr 3, 2018

Ok, I now see that this issue is much more difficult than I expected it to be. If we join single TOML with table a on top-level and TOML with single table a.b on top-level we need to perform some smart concatenation.

Another solution: store only single component per TOML level. This simplifies joining. But compilcates pretty-printing and parsing...

@chshersh chshersh mentioned this issue Apr 9, 2018
Closed
@chshersh chshersh added this to the v1.0.0: Public release milestone Jun 3, 2018
vrom911 added a commit that referenced this issue Jun 3, 2018
@vrom911
[#10] Add Semigroup and Monoid instances TOML
6dd7ecd
@vrom911 vrom911 mentioned this issue Jun 3, 2018
Merged
@vrom911 vrom911 removed their assignment Jun 12, 2018
vrom911 added a commit that referenced this issue Jun 14, 2018
@vrom911
[#10] Add Semigroup and Monoid instances TOML
e60b66d
chshersh pushed a commit that referenced this issue Jun 14, 2018
@vrom911 @chshersh
[#10] Add Semigroup and Monoid instances TOML (#57)
533e2d5 
* [#10] Add Semigroup and Monoid instances TOML

* Fix after review

* Add tests for Semigroup and Monoid insts

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
ast Type of TOML
Projects
None yet
Milestone
v1.0.0: Public release
Development

No branches or pull requests
2 participants
@chshersh @vrom911